grpc
/
grpc-java
mirror of https://github.com/grpc/grpc-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

api: Allow streaming methods to be safe

This commit is contained in:
Eric Anderson 2019-10-16 09:06:47 -07:00
parent ddaf1c8ce9
commit fa45a71ec9
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
api/src/main/java/io/grpc/MethodDescriptor.java
View File

@ -234,8 +234,6 @@ public final class MethodDescriptor<ReqT, RespT> {
this.idempotent = idempotent; this.idempotent = idempotent;
this.safe = safe; this.safe = safe;
this.sampledToLocalTracing = sampledToLocalTracing; this.sampledToLocalTracing = sampledToLocalTracing;
Preconditions.checkArgument(!safe || type == MethodType.UNARY,
"Only unary methods can be specified safe");
} }
/** /**

5
api/src/test/java/io/grpc/MethodDescriptorTest.java
View File

@ -102,8 +102,9 @@ public class MethodDescriptorTest {
.setResponseMarshaller(new StringMarshaller()) .setResponseMarshaller(new StringMarshaller())
.build(); .build();
thrown.expect(IllegalArgumentException.class); // Verify it does not throw
MethodDescriptor<String, String> unused = descriptor.toBuilder().setSafe(true).build(); MethodDescriptor<String, String> newDescriptor = descriptor.toBuilder().setSafe(true).build();
assertTrue(newDescriptor.isSafe());
} }
@Test @Test