From fe5511cf21a88dbcdfad1d885ccf1f7bbeac1ab5 Mon Sep 17 00:00:00 2001 From: Eric Anderson Date: Mon, 2 May 2022 09:48:33 -0700 Subject: [PATCH] benchmarks: Use Truth in LoadWorkerTest This will produce better error messages when the comparisons fail. This is to help debug aarch64 test failures. --- .../java/io/grpc/benchmarks/driver/LoadWorkerTest.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/benchmarks/src/test/java/io/grpc/benchmarks/driver/LoadWorkerTest.java b/benchmarks/src/test/java/io/grpc/benchmarks/driver/LoadWorkerTest.java index 2f8b7a0ea2..b368c44847 100644 --- a/benchmarks/src/test/java/io/grpc/benchmarks/driver/LoadWorkerTest.java +++ b/benchmarks/src/test/java/io/grpc/benchmarks/driver/LoadWorkerTest.java @@ -16,7 +16,7 @@ package io.grpc.benchmarks.driver; -import static org.junit.Assert.assertTrue; +import static com.google.common.truth.Truth.assertThat; import static org.junit.Assert.fail; import io.grpc.ManagedChannel; @@ -194,12 +194,12 @@ public class LoadWorkerTest { } } clientObserver.onCompleted(); - assertTrue(stat.hasLatencies()); - assertTrue(stat.getLatencies().getCount() < stat.getLatencies().getSum()); + assertThat(stat.hasLatencies()).isTrue(); + assertThat(stat.getLatencies().getCount()).isLessThan(stat.getLatencies().getSum()); double mean = stat.getLatencies().getSum() / stat.getLatencies().getCount(); System.out.println("Mean " + mean + " us"); - assertTrue(mean > stat.getLatencies().getMinSeen()); - assertTrue(mean < stat.getLatencies().getMaxSeen()); + assertThat(stat.getLatencies().getMinSeen()).isLessThan(mean); + assertThat(stat.getLatencies().getMaxSeen()).isGreaterThan(mean); } private StreamObserver startClient(Control.ClientArgs clientArgs)