mirror of https://github.com/grpc/grpc-node.git
Fix client crash on custom error code
This commit is contained in:
parent
7e4c8f058c
commit
15d422d5bb
|
|
@ -398,7 +398,7 @@ export class RetryingCall implements Call, DeadlineInfoProvider {
|
||||||
return list.some(
|
return list.some(
|
||||||
value =>
|
value =>
|
||||||
value === code ||
|
value === code ||
|
||||||
value.toString().toLowerCase() === Status[code].toLowerCase()
|
value.toString().toLowerCase() === Status[code]?.toLowerCase()
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -323,6 +323,21 @@ describe('Retries', () => {
|
||||||
}
|
}
|
||||||
);
|
);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('Should not retry on custom error code', done => {
|
||||||
|
const metadata = new grpc.Metadata();
|
||||||
|
metadata.set('succeed-on-retry-attempt', '2');
|
||||||
|
metadata.set('respond-with-status', '300');
|
||||||
|
client.echo(
|
||||||
|
{ value: 'test value', value2: 3 },
|
||||||
|
metadata,
|
||||||
|
(error: grpc.ServiceError, response: any) => {
|
||||||
|
assert(error);
|
||||||
|
assert.strictEqual(error.details, 'Failed on retry 0');
|
||||||
|
done();
|
||||||
|
}
|
||||||
|
);
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
describe('Client with hedging configured', () => {
|
describe('Client with hedging configured', () => {
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue