grpc
/
grpc-node
mirror of https://github.com/grpc/grpc-node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1851 from murgatroid99/grpc-js_logging_severity_methods 

grpc-js: Split out logs for different severity levels
This commit is contained in:
Michael Lumish 2021-07-16 16:40:52 -07:00 committed by GitHub
parent 08423d62ac 6359bf066f
commit 19f8da1b34
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 34 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
packages/grpc-js/src/logging.ts
View File

@ -17,7 +17,19 @@
import { LogVerbosity } from './constants';
let _logger: Partial<Console> = console;
const DEFAULT_LOGGER: Partial<Console> = {
error: (message?: any, ...optionalParams: any[]) => {
console.error('E ' + message, ...optionalParams);
},
info: (message?: any, ...optionalParams: any[]) => {
console.error('I ' + message, ...optionalParams);
},
debug: (message?: any, ...optionalParams: any[]) => {
console.error('D ' + message, ...optionalParams);
},
}
let _logger: Partial<Console> = DEFAULT_LOGGER;
let _logVerbosity: LogVerbosity = LogVerbosity.ERROR;
const verbosityString =
@ -54,8 +66,27 @@ export const setLoggerVerbosity = (verbosity: LogVerbosity): void => {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
export const log = (severity: LogVerbosity, ...args: any[]): void => {
if (severity >= _logVerbosity && typeof _logger.error === 'function') {
_logger.error(...args);
let logFunction: typeof DEFAULT_LOGGER.error;
if (severity >= _logVerbosity) {
switch (severity) {
case LogVerbosity.DEBUG:
logFunction = _logger.debug;
break;
case LogVerbosity.INFO:
logFunction = _logger.info;
break;
case LogVerbosity.ERROR:
logFunction = _logger.error;
break;
}
/* Fall back to _logger.error when other methods are not available for
* compatiblity with older behavior that always logged to _logger.error */
if (!logFunction) {
logFunction = _logger.error;
}
if (logFunction) {
logFunction.bind(_logger)(...args);
}
}
};

4
packages/grpc-js/test/test-logging.ts
View File

@ -27,10 +27,6 @@ describe('Logging', () => {
grpc.setLogVerbosity(grpc.logVerbosity.DEBUG);
});
it('logger defaults to console', () => {
assert.strictEqual(logging.getLogger(), console);
});
it('sets the logger to a new value', () => {
const logger: Partial<Console> = {};