grpc
/
grpc-node
mirror of https://github.com/grpc/grpc-node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

In server.bindAsync, call callback in process.nextTick

This commit is contained in:
Michael Lumish 2021-09-28 13:14:14 -07:00
parent 157882da45
commit 1eea4b75bd
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
packages/grpc-js/src/server.ts
View File

@ -268,6 +268,10 @@ export class Server {
}; };
} }
const deferredCallback = (error: Error | null, port: number) => {
process.nextTick(() => callback(error, port));
}
const setupServer = (): http2.Http2Server | http2.Http2SecureServer => { const setupServer = (): http2.Http2Server | http2.Http2SecureServer => {
let http2Server: http2.Http2Server | http2.Http2SecureServer; let http2Server: http2.Http2Server | http2.Http2SecureServer;
if (creds._isSecure()) { if (creds._isSecure()) {
@ -386,7 +390,7 @@ export class Server {
// We only want one resolution result. Discard all future results // We only want one resolution result. Discard all future results
resolverListener.onSuccessfulResolution = () => {}; resolverListener.onSuccessfulResolution = () => {};
if (addressList.length === 0) { if (addressList.length === 0) {
callback(new Error(`No addresses resolved for port ${port}`), 0); deferredCallback(new Error(`No addresses resolved for port ${port}`), 0);
return; return;
} }
let bindResultPromise: Promise<BindResult>; let bindResultPromise: Promise<BindResult>;
@ -409,7 +413,7 @@ export class Server {
if (bindResult.count === 0) { if (bindResult.count === 0) {
const errorString = `No address added out of total ${addressList.length} resolved`; const errorString = `No address added out of total ${addressList.length} resolved`;
logging.log(LogVerbosity.ERROR, errorString); logging.log(LogVerbosity.ERROR, errorString);
callback(new Error(errorString), 0); deferredCallback(new Error(errorString), 0);
} else { } else {
if (bindResult.count < addressList.length) { if (bindResult.count < addressList.length) {
logging.log( logging.log(
@ -417,18 +421,18 @@ export class Server {
`WARNING Only ${bindResult.count} addresses added out of total ${addressList.length} resolved` `WARNING Only ${bindResult.count} addresses added out of total ${addressList.length} resolved`
); );
} }
callback(null, bindResult.port); deferredCallback(null, bindResult.port);
} }
}, },
(error) => { (error) => {
const errorString = `No address added out of total ${addressList.length} resolved`; const errorString = `No address added out of total ${addressList.length} resolved`;
logging.log(LogVerbosity.ERROR, errorString); logging.log(LogVerbosity.ERROR, errorString);
callback(new Error(errorString), 0); deferredCallback(new Error(errorString), 0);
} }
); );
}, },
onError: (error) => { onError: (error) => {
callback(new Error(error.details), 0); deferredCallback(new Error(error.details), 0);
}, },
}; };