From 212439eb83d7f12306c842dbe4194198494ee54b Mon Sep 17 00:00:00 2001
From: cjihrig <cjihrig@gmail.com>
Date: Fri, 17 May 2019 11:40:29 -0400
Subject: [PATCH] grpc-js: make serdes APIs consistent

During initial implementation, the serialize and deserialize
APIs of ServerReadableStream, ServerWritableStream, and
ServerDuplexStream became inconsistent. This commit brings
back consistency.
---
 packages/grpc-js/src/server-call.ts | 17 ++---------------
 1 file changed, 2 insertions(+), 15 deletions(-)

diff --git a/packages/grpc-js/src/server-call.ts b/packages/grpc-js/src/server-call.ts
index 8ecb91d2..d52ea3cd 100644
--- a/packages/grpc-js/src/server-call.ts
+++ b/packages/grpc-js/src/server-call.ts
@@ -104,8 +104,7 @@ export class ServerReadableStreamImpl<RequestType, ResponseType> extends
 
   constructor(
       private call: Http2ServerCallStream<RequestType, ResponseType>,
-      public metadata: Metadata,
-      private _deserialize: Deserialize<RequestType>) {
+      public metadata: Metadata, public deserialize: Deserialize<RequestType>) {
     super({objectMode: true});
     this.cancelled = false;
     this.call.setupReadable(this);
@@ -115,10 +114,6 @@ export class ServerReadableStreamImpl<RequestType, ResponseType> extends
     this.call.resume();
   }
 
-  deserialize(input: Buffer): RequestType {
-    return this._deserialize(input);
-  }
-
   getPeer(): string {
     throw new Error('not implemented yet');
   }
@@ -137,7 +132,7 @@ export class ServerWritableStreamImpl<RequestType, ResponseType> extends
 
   constructor(
       private call: Http2ServerCallStream<RequestType, ResponseType>,
-      public metadata: Metadata, private _serialize: Serialize<ResponseType>) {
+      public metadata: Metadata, public serialize: Serialize<ResponseType>) {
     super({objectMode: true});
     this.cancelled = false;
     this.request = null;
@@ -190,14 +185,6 @@ export class ServerWritableStreamImpl<RequestType, ResponseType> extends
 
     super.end();
   }
-
-  serialize(input: ResponseType): Buffer|null {
-    if (input === null || input === undefined) {
-      return null;
-    }
-
-    return this._serialize(input);
-  }
 }