Fix options type check

This commit is contained in:
Michael Lumish 2020-03-24 11:12:40 -07:00
parent 91dc475dd5
commit 22521ef8a7
1 changed files with 4 additions and 2 deletions

View File

@ -146,8 +146,10 @@ export class ChannelImplementation implements Channel {
if (!(credentials instanceof ChannelCredentials)) { if (!(credentials instanceof ChannelCredentials)) {
throw new TypeError('Channel credentials must be a ChannelCredentials object'); throw new TypeError('Channel credentials must be a ChannelCredentials object');
} }
if ((typeof options !== 'object') || !Object.values(options).every(value => typeof value === 'string' || typeof value === 'number')) { if (options) {
throw new TypeError('Channel options must be an object with string or number values'); if ((typeof options !== 'object') || !Object.values(options).every(value => typeof value === 'string' || typeof value === 'number')) {
throw new TypeError('Channel options must be an object with string or number values');
}
} }
/* The global boolean parameter to getSubchannelPool has the inverse meaning to what /* The global boolean parameter to getSubchannelPool has the inverse meaning to what
* the grpc.use_local_subchannel_pool channel option means. */ * the grpc.use_local_subchannel_pool channel option means. */