Address review comments

This commit is contained in:
Michael Lumish 2021-03-31 13:22:08 -07:00
parent 4742f9d57e
commit 3ac1e6ddb8
2 changed files with 12 additions and 14 deletions

View File

@ -694,9 +694,6 @@ function runScript() {
.normalize(['includeDirs', 'outDir'])
.array('includeDirs')
.boolean(['keepCase', 'defaults', 'arrays', 'objects', 'oneofs', 'json', 'verbose', 'includeComments'])
// .choices('longs', ['String', 'Number'])
// .choices('enums', ['String'])
// .choices('bytes', ['Array', 'String'])
.string(['longs', 'enums', 'bytes'])
.coerce('longs', value => {
switch (value) {
@ -748,8 +745,9 @@ function runScript() {
console.log('Success');
}
}, (error) => {
throw error;
})
console.error(error)
process.exit(1);
});
}
if (require.main === module) {

View File

@ -24,6 +24,8 @@ import { loadProtosWithOptionsSync, loadProtosWithOptions, Options, addCommonPro
export { Long } from 'long';
export { Options };
/**
* This type exists for use with code generated by the proto-loader-gen-types
* tool. This type should be used with another interface, e.g.
@ -139,8 +141,6 @@ export interface PackageDefinition {
[index: string]: AnyDefinition;
}
export { Options };
type DecodedDescriptorSet = Protobuf.Message<descriptor.IFileDescriptorSet> &
descriptor.IFileDescriptorSet;