mirror of https://github.com/grpc/grpc-node.git
Merge pull request #643 from JustinBeckwith/each
refactor: drop usage of _.each
This commit is contained in:
commit
4071bf85a8
|
@ -378,7 +378,8 @@ function Client(address, credentials, options) {
|
|||
}
|
||||
self.$interceptors = options.interceptors || [];
|
||||
self.$interceptor_providers = options.interceptor_providers || [];
|
||||
_.each(self.$method_definitions, function(method_definition, method_name) {
|
||||
Object.keys(self.$method_definitions).forEach(method_name => {
|
||||
const method_definition = self.$method_definitions[method_name];
|
||||
self[method_name].interceptors = client_interceptors
|
||||
.resolveInterceptorProviders(self.$interceptor_providers, method_definition)
|
||||
.concat(self.$interceptors);
|
||||
|
@ -934,7 +935,8 @@ exports.makeClientConstructor = function(methods, serviceName,
|
|||
ServiceClient.prototype.$method_definitions = methods;
|
||||
ServiceClient.prototype.$method_names = {};
|
||||
|
||||
_.each(methods, function(attrs, name) {
|
||||
Object.keys(methods).forEach(name => {
|
||||
const attrs = methods[name];
|
||||
if (name.indexOf('$') === 0) {
|
||||
throw new Error('Method names cannot start with $');
|
||||
}
|
||||
|
|
|
@ -144,7 +144,8 @@ exports.loadObject = function loadObject(value, options) {
|
|||
return loadObject(value.ns, options);
|
||||
}
|
||||
if (value.className === 'Namespace') {
|
||||
_.each(value.children, function(child) {
|
||||
Object.keys(value.children).forEach(key => {
|
||||
const child = value.children[key];
|
||||
result[child.name] = loadObject(child, options);
|
||||
});
|
||||
return result;
|
||||
|
|
|
@ -137,7 +137,8 @@ exports.loadObject = function loadObject(value, options) {
|
|||
|
||||
if (value.hasOwnProperty('nested')) {
|
||||
// It's a namespace or root object
|
||||
_.each(value.nested, function(nested, name) {
|
||||
Object.keys(value.nested).forEach(name => {
|
||||
const nested = value.nested[name];
|
||||
result[name] = loadObject(nested, options);
|
||||
});
|
||||
return result;
|
||||
|
|
Loading…
Reference in New Issue