From 482006e286172661a899e09ffe213fb373025dbc Mon Sep 17 00:00:00 2001 From: Michael Lumish Date: Fri, 4 Apr 2025 12:41:04 -0700 Subject: [PATCH] grpc-js: Avoid calling http2.getDefaultSettings --- packages/grpc-js/src/transport.ts | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/packages/grpc-js/src/transport.ts b/packages/grpc-js/src/transport.ts index d14a2227..4d69b7f4 100644 --- a/packages/grpc-js/src/transport.ts +++ b/packages/grpc-js/src/transport.ts @@ -695,16 +695,17 @@ export class Http2SubchannelConnector implements SubchannelConnector { reject(`${errorMessage} (${new Date().toISOString()})`); } }; - const session = http2.connect(`${scheme}://${targetPath}`, { + const sessionOptions: http2.ClientSessionOptions = { createConnection: (authority, option) => { return secureConnectResult.socket; - }, - settings: { - initialWindowSize: - options['grpc-node.flow_control_window'] ?? - http2.getDefaultSettings().initialWindowSize, } - }); + }; + if (options['grpc-node.flow_control_window'] !== undefined) { + sessionOptions.settings = { + initialWindowSize: options['grpc-node.flow_control_window'] + }; + } + const session = http2.connect(`${scheme}://${targetPath}`, sessionOptions); this.session = session; let errorMessage = 'Failed to connect'; let reportedError = false;