Merge pull request #608 from cjihrig/rename

Rename grpc-js-core and grpc-protobufjs to match npm

README.md

@@ -15,7 +15,7 @@ This is the existing, feature-rich implementation of gRPC using a C++ addon. It
 
 ### Pure JavaScript Client
 
-Directory: [`packages/grpc-js-core`](https://github.com/grpc/grpc-node/tree/master/packages/grpc-js-core)
+Directory: [`packages/grpc-js`](https://github.com/grpc/grpc-node/tree/master/packages/grpc-js)
 
 npm package: [@grpc/grpc-js](https://www.npmjs.com/package/@grpc/grpc-js)
 
@@ -27,7 +27,7 @@ This library implements the core functionality of gRPC purely in JavaScript, wit
 
 ### gRPC Protobuf Loader
 
-Directory: [`packages/grpc-protobufjs`](https://github.com/grpc/grpc-node/tree/master/packages/grpc-protobufjs)
+Directory: [`packages/proto-loader`](https://github.com/grpc/grpc-node/tree/master/packages/proto-loader)
 
 npm package: [@grpc/proto-loader](https://www.npmjs.com/package/@grpc/proto-loader)
 

gulpfile.ts

@@ -49,9 +49,9 @@ function loadGulpTasksWithPrefix(path: string, prefix: string) {
 
 [
   ['./packages/grpc-health-check/gulpfile', 'health-check'],
-  ['./packages/grpc-js-core/gulpfile', 'js.core'],
+  ['./packages/grpc-js/gulpfile', 'js.core'],
   ['./packages/grpc-native-core/gulpfile', 'native.core'],
-  ['./packages/grpc-protobufjs/gulpfile', 'protobuf'],
+  ['./packages/proto-loader/gulpfile', 'protobuf'],
   ['./test/gulpfile', 'internal.test'],
 ].forEach((args) => loadGulpTasksWithPrefix(args[0], args[1]));
 

package.json

@@ -55,10 +55,10 @@
   "nyc": {
     "include": [
       "packages/grpc-health-check/health.js",
-      "packages/grpc-js-core/build/src/*",
+      "packages/grpc-js/build/src/*",
       "packages/grpc-native-core/index.js",
       "packages/grpc-native-core/src/*.js",
-      "packages/grpc-protobufjs/build/src/*"
+      "packages/proto-loader/build/src/*"
     ],
     "cache": true,
     "all": true

packages/grpc-js/package.json

@@ -3,7 +3,7 @@
   "version": "0.3.2",
   "description": "gRPC Library for Node - pure JS implementation",
   "homepage": "https://grpc.io/",
-  "repository": "https://github.com/grpc/grpc-node/tree/master/packages/grpc-js-core",
+  "repository": "https://github.com/grpc/grpc-node/tree/master/packages/grpc-js",
   "main": "build/src/index.js",
   "engines": {
     "node": "^8.11.2 || >=9.4"

test/any_grpc.js

@@ -5,14 +5,18 @@
 const _ = require('lodash');
 
 function getImplementation(globalField) {
-  if (global[globalField] !== 'js' && global[globalField] !== 'native') {
-    throw new Error([
-      `Invalid value for global.${globalField}: ${global.globalField}.`,
-      'If running from the command line, please --require a fixture first.'
-    ].join(' '));
-  }
   const impl = global[globalField];
-  return require(`../packages/grpc-${impl}-core`);
+
+  if (impl === 'js') {
+    return require(`../packages/grpc-${impl}`);
+  } else if (impl === 'native') {
+    return require(`../packages/grpc-${impl}-core`);
+  }
+
+  throw new Error([
+    `Invalid value for global.${globalField}: ${global.globalField}.`,
+    'If running from the command line, please --require a fixture first.'
+  ].join(' '));
 }
 
 const clientImpl = getImplementation('_client_implementation');

test/api/error_test.js

@@ -10,7 +10,7 @@ const _ = require('lodash');
 const anyGrpc = require('../any_grpc');
 const clientGrpc = anyGrpc.client;
 const serverGrpc = anyGrpc.server;
-const protoLoader = require('../../packages/grpc-protobufjs', options);
+const protoLoader = require('../../packages/proto-loader', options);
 const testServiceDef = protoLoader.loadSync(__dirname + '/../proto/test_service.proto');
 const TestServiceClient = clientGrpc.loadPackageDefinition(testServiceDef).TestService;
 const clientInsecureCreds = clientGrpc.credentials.createInsecure();
@@ -526,4 +526,4 @@ describe('Client malformed response handling', function() {
         });
       });
     });
-});
+});

test/client-libraries-integration/use-grpc-js.js

@@ -2,9 +2,9 @@ require('source-map-support/register');
 const Module = require('module');
 const shimmer = require('shimmer');
 
-const grpcPJson = require('../../packages/grpc-js-core/package');
+const grpcPJson = require('../../packages/grpc-js/package');
-const grpcImpl = require('../../packages/grpc-js-core');
+const grpcImpl = require('../../packages/grpc-js');
-const grpcProtobuf = require('../../packages/grpc-protobufjs');
+const grpcProtobuf = require('../../packages/proto-loader');
 
 if (!process.env.USE_GRPC_NATIVE) {
   shimmer.wrap(Module, '_load', (moduleLoad) => {

test/interop/interop_client.js

@@ -21,7 +21,7 @@
 var fs = require('fs');
 var path = require('path');
 var grpc = require('../any_grpc').client;
-var protoLoader = require('../../packages/grpc-protobufjs');
+var protoLoader = require('../../packages/proto-loader');
 var GoogleAuth = require('google-auth-library');
 
 var protoPackage = protoLoader.loadSync(

test/interop/interop_server.js

@@ -24,7 +24,7 @@ var _ = require('lodash');
 var AsyncDelayQueue = require('./async_delay_queue');
 var grpc = require('../any_grpc').server;
 // TODO(murgatroid99): do this import more cleanly
-var protoLoader = require('../../packages/grpc-protobufjs');
+var protoLoader = require('../../packages/proto-loader');
 var protoPackage = protoLoader.loadSync(
     'src/proto/grpc/testing/test.proto',
     {keepCase: true,

test/performance/benchmark_client.js

@@ -37,7 +37,7 @@ var genericService = require('./generic_service');
 
 // TODO(murgatroid99): use multiple grpc implementations
 var grpc = require('../any_grpc').client;
-var protoLoader = require('../../packages/grpc-protobufjs');
+var protoLoader = require('../../packages/proto-loader');
 var protoPackage = protoLoader.loadSync(
     'src/proto/grpc/testing/benchmark_service.proto',
     {keepCase: true,

test/performance/benchmark_server.js

@@ -31,7 +31,7 @@ var util = require('util');
 var genericService = require('./generic_service');
 
 var grpc = require('../any_grpc').server;
-var protoLoader = require('../../packages/grpc-protobufjs');
+var protoLoader = require('../../packages/proto-loader');
 var protoPackage = protoLoader.loadSync(
     'src/proto/grpc/testing/benchmark_service.proto',
     {keepCase: true,

test/performance/worker.js

@@ -22,7 +22,7 @@ var console = require('console');
 var WorkerServiceImpl = require('./worker_service_impl');
 
 var grpc = require('../any_grpc').server;
-var protoLoader = require('../../packages/grpc-protobufjs');
+var protoLoader = require('../../packages/proto-loader');
 var protoPackage = protoLoader.loadSync(
     'src/proto/grpc/testing/worker_service.proto',
     {keepCase: true,