grpc
/
grpc-node
mirror of https://github.com/grpc/grpc-node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

grpc-js: Report error when no message received for unary response

This commit is contained in:
Michael Lumish 2022-04-19 13:18:59 -07:00
parent fa92727ec7
commit 5311c03867
1 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
packages/grpc-js/src/client.ts
View File

@ -338,7 +338,15 @@ export class Client {
} }
receivedStatus = true; receivedStatus = true;
if (status.code === Status.OK) { if (status.code === Status.OK) {
callProperties.callback!(null, responseMessage!); if (responseMessage === null) {
callProperties.callback!(callErrorFromStatus({
code: Status.INTERNAL,
details: 'No message received',
metadata: status.metadata
}));
} else {
callProperties.callback!(null, responseMessage);
}
} else { } else {
callProperties.callback!(callErrorFromStatus(status)); callProperties.callback!(callErrorFromStatus(status));
} }
@ -455,7 +463,15 @@ export class Client {
} }
receivedStatus = true; receivedStatus = true;
if (status.code === Status.OK) { if (status.code === Status.OK) {
callProperties.callback!(null, responseMessage!); if (responseMessage === null) {
callProperties.callback!(callErrorFromStatus({
code: Status.INTERNAL,
details: 'No message received',
metadata: status.metadata
}));
} else {
callProperties.callback!(null, responseMessage);
}
} else { } else {
callProperties.callback!(callErrorFromStatus(status)); callProperties.callback!(callErrorFromStatus(status));
} }