grpc
/
grpc-node
mirror of https://github.com/grpc/grpc-node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

grpc-js-core: remove use of deprecated Buffer() constructor 

The Buffer() constructor should not be used. This commit
replaces its use in grpc-js-core tests with Buffer.from().
This commit is contained in:
cjihrig 2018-08-25 11:31:23 -04:00
parent 28cc8447c8
commit 7528efbd32
No known key found for this signature in database
GPG Key ID: 7434390BDBE9B9C5
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/grpc-js-core/test/test-metadata.ts
View File

@ -30,7 +30,7 @@ describe('Metadata', () => {
describe('set', () => {
it('Only accepts string values for non "-bin" keys', () => {
assert.throws(() => {
metadata.set('key', new Buffer('value'));
metadata.set('key', Buffer.from('value'));
});
assert.doesNotThrow(() => {
metadata.set('key', 'value');
@ -42,7 +42,7 @@ describe('Metadata', () => {
metadata.set('key-bin', 'value');
});
assert.doesNotThrow(() => {
metadata.set('key-bin', new Buffer('value'));
metadata.set('key-bin', Buffer.from('value'));
});
});
@ -89,7 +89,7 @@ describe('Metadata', () => {
describe('add', () => {
it('Only accepts string values for non "-bin" keys', () => {
assert.throws(() => {
metadata.add('key', new Buffer('value'));
metadata.add('key', Buffer.from('value'));
});
assert.doesNotThrow(() => {
metadata.add('key', 'value');
@ -101,7 +101,7 @@ describe('Metadata', () => {
metadata.add('key-bin', 'value');
});
assert.doesNotThrow(() => {
metadata.add('key-bin', new Buffer('value'));
metadata.add('key-bin', Buffer.from('value'));
});
});
@ -151,7 +151,7 @@ describe('Metadata', () => {
beforeEach(() => {
metadata.add('key', 'value1');
metadata.add('key', 'value2');
metadata.add('key-bin', new Buffer('value'));
metadata.add('key-bin', Buffer.from('value'));
});
it('gets all values associated with a key', () => {