grpc
/
grpc-node
mirror of https://github.com/grpc/grpc-node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactor: drop usage of _.bind

This commit is contained in:
Justin Beckwith 2018-11-12 22:16:15 -08:00
parent f70eabb1ec
commit 7a92e7cd19
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/grpc-native-core/src/server.js
View File

@ -871,14 +871,15 @@ Server.prototype.addService = function(service, implementation) {
if (!_.isObject(service) || !_.isObject(implementation)) { if (!_.isObject(service) || !_.isObject(implementation)) {
throw new Error('addService requires two objects as arguments'); throw new Error('addService requires two objects as arguments');
} }
if (_.keys(service).length === 0) { if (Object.keys(service).length === 0) {
throw new Error('Cannot add an empty service to a server'); throw new Error('Cannot add an empty service to a server');
} }
if (this.started) { if (this.started) {
throw new Error('Can\'t add a service to a started server.'); throw new Error('Can\'t add a service to a started server.');
} }
var self = this; var self = this;
_.forOwn(service, function(attrs, name) { Object.keys(service).forEach(key => {
const attrs = service[key];
var method_type; var method_type;
if (attrs.requestStream) { if (attrs.requestStream) {
if (attrs.responseStream) { if (attrs.responseStream) {
@ -903,10 +904,10 @@ Server.prototype.addService = function(service, implementation) {
' for ' + attrs.path + ' expected but not provided'); ' for ' + attrs.path + ' expected but not provided');
impl = defaultHandler[method_type]; impl = defaultHandler[method_type];
} else { } else {
impl = _.bind(implementation[attrs.originalName], implementation); impl = implementation[attrs.originalName].bind(implementation);
} }
} else { } else {
impl = _.bind(implementation[name], implementation); impl = implementation[name].bind(implementation);
} }
var serialize = attrs.responseSerialize; var serialize = attrs.responseSerialize;
var deserialize = attrs.requestDeserialize; var deserialize = attrs.requestDeserialize;