refactor: use lodash subpackages

This commit is contained in:
Justin Beckwith 2018-11-20 13:41:34 -08:00
parent 4a9bf57f29
commit 8f8dd7b2d6
11 changed files with 10 additions and 20 deletions

View File

@ -24,8 +24,6 @@ var util = require('util');
var SSL_ROOTS_PATH = path.resolve(__dirname, 'deps', 'grpc', 'etc', 'roots.pem'); var SSL_ROOTS_PATH = path.resolve(__dirname, 'deps', 'grpc', 'etc', 'roots.pem');
var _ = require('lodash');
var ProtoBuf = require('protobufjs'); var ProtoBuf = require('protobufjs');
var client = require('./src/client.js'); var client = require('./src/client.js');

View File

@ -29,7 +29,8 @@
"node-pre-gyp" "node-pre-gyp"
], ],
"dependencies": { "dependencies": {
"lodash": "^4.17.5", "lodash.camelcase": "^4.3.0",
"lodash.clone": "^4.5.0",
"nan": "^2.0.0", "nan": "^2.0.0",
"node-pre-gyp": "^0.12.0", "node-pre-gyp": "^0.12.0",
"protobufjs": "^5.0.3" "protobufjs": "^5.0.3"

View File

@ -32,8 +32,6 @@
'use strict'; 'use strict';
var _ = require('lodash');
var client_interceptors = require('./client_interceptors'); var client_interceptors = require('./client_interceptors');
var grpc = require('./grpc_extension'); var grpc = require('./grpc_extension');
@ -949,7 +947,7 @@ exports.makeClientConstructor = function(methods, serviceName,
} }
var method_type = common.getMethodType(attrs); var method_type = common.getMethodType(attrs);
var method_func = function() { var method_func = function() {
return requester_funcs[method_type].apply(this, return requester_funcs[method_type].apply(this,
[ attrs.path, attrs.requestSerialize, attrs.responseDeserialize ] [ attrs.path, attrs.requestSerialize, attrs.responseDeserialize ]
.concat([].slice.call(arguments)) .concat([].slice.call(arguments))
); );

View File

@ -141,7 +141,6 @@
'use strict'; 'use strict';
var _ = require('lodash');
var grpc = require('./grpc_extension'); var grpc = require('./grpc_extension');
var Metadata = require('./metadata'); var Metadata = require('./metadata');
var constants = require('./constants'); var constants = require('./constants');

View File

@ -18,7 +18,6 @@
'use strict'; 'use strict';
var _ = require('lodash');
var constants = require('./constants'); var constants = require('./constants');
/** /**

View File

@ -69,8 +69,6 @@ var common = require('./common.js');
var constants = require('./constants'); var constants = require('./constants');
var _ = require('lodash');
/** /**
* @external GoogleCredential * @external GoogleCredential
* @see https://github.com/google/google-auth-library-nodejs * @see https://github.com/google/google-auth-library-nodejs

View File

@ -18,7 +18,7 @@
'use strict'; 'use strict';
var _ = require('lodash'); var clone = require('lodash.clone');
var grpc = require('./grpc_extension'); var grpc = require('./grpc_extension');
@ -139,7 +139,7 @@ Metadata.prototype.clone = function() {
var copy = new Metadata(); var copy = new Metadata();
Object.keys(this._internal_repr).forEach(key => { Object.keys(this._internal_repr).forEach(key => {
const value = this._internal_repr[key]; const value = this._internal_repr[key];
copy._internal_repr[key] = _.clone(value); copy._internal_repr[key] = clone(value);
}); });
return copy; return copy;
}; };
@ -166,7 +166,7 @@ Metadata._fromCoreRepresentation = function(metadata) {
if (metadata) { if (metadata) {
Object.keys(metadata).forEach(key => { Object.keys(metadata).forEach(key => {
const value = metadata[key]; const value = metadata[key];
newMetadata._internal_repr[key] = _.clone(value); newMetadata._internal_repr[key] = clone(value);
}); });
} }
return newMetadata; return newMetadata;

View File

@ -23,7 +23,7 @@
'use strict'; 'use strict';
var _ = require('lodash'); var camelCase = require('lodash.camelcase');
var client = require('./client'); var client = require('./client');
var common = require('./common'); var common = require('./common');
@ -108,7 +108,7 @@ exports.getProtobufServiceAttrs = function getProtobufServiceAttrs(service,
_.fromPairs, which would be cleaner, but was introduced in lodash _.fromPairs, which would be cleaner, but was introduced in lodash
version 4 */ version 4 */
return common.zipObject(service.children.map(function(method) { return common.zipObject(service.children.map(function(method) {
return _.camelCase(method.name); return camelCase(method.name);
}), service.children.map(function(method) { }), service.children.map(function(method) {
return { return {
originalName: method.name, originalName: method.name,

View File

@ -23,7 +23,7 @@
'use strict'; 'use strict';
var _ = require('lodash'); var camelCase = require('lodash.camelcase');
var client = require('./client'); var client = require('./client');
var common = require('./common'); var common = require('./common');
@ -105,7 +105,7 @@ exports.getProtobufServiceAttrs = function getProtobufServiceAttrs(service,
var prefix = '/' + fullyQualifiedName(service) + '/'; var prefix = '/' + fullyQualifiedName(service) + '/';
service.resolveAll(); service.resolveAll();
return common.zipObject(service.methods.map(function(method) { return common.zipObject(service.methods.map(function(method) {
return _.camelCase(method.name); return camelCase(method.name);
}), service.methods.map(function(method) { }), service.methods.map(function(method) {
return { return {
originalName: method.name, originalName: method.name,

View File

@ -18,8 +18,6 @@
'use strict'; 'use strict';
var _ = require('lodash');
var grpc = require('./grpc_extension'); var grpc = require('./grpc_extension');
var common = require('./common'); var common = require('./common');

View File

@ -19,7 +19,6 @@
'use strict'; 'use strict';
var assert = require('assert'); var assert = require('assert');
var _ = require('lodash');
var common = require('../src/common'); var common = require('../src/common');
var protobuf_js_5_common = require('../src/protobuf_js_5_common'); var protobuf_js_5_common = require('../src/protobuf_js_5_common');