From a0914c6cdada66e66c4e20839d93b160129543c2 Mon Sep 17 00:00:00 2001 From: Ricki Hastings Date: Thu, 2 Jan 2025 08:56:53 +0000 Subject: [PATCH] fix: rename variable and use nullish coalesce --- packages/grpc-js/README.md | 2 +- packages/grpc-js/src/channel-options.ts | 2 +- packages/grpc-js/src/transport.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/grpc-js/README.md b/packages/grpc-js/README.md index 42d57985..7b1ff43c 100644 --- a/packages/grpc-js/README.md +++ b/packages/grpc-js/README.md @@ -70,7 +70,7 @@ Many channel arguments supported in `grpc` are not supported in `@grpc/grpc-js`. - `grpc-node.max_session_memory` - `grpc-node.tls_enable_trace` - `grpc-node.retry_max_attempts_limit` - - `grpc-node.http2_initial_window_size` + - `grpc-node.flow_control_window` - `channelOverride` - `channelFactoryOverride` diff --git a/packages/grpc-js/src/channel-options.ts b/packages/grpc-js/src/channel-options.ts index 04c26b03..32c9df6b 100644 --- a/packages/grpc-js/src/channel-options.ts +++ b/packages/grpc-js/src/channel-options.ts @@ -64,7 +64,7 @@ export interface ChannelOptions { 'grpc-node.tls_enable_trace'?: number; 'grpc.lb.ring_hash.ring_size_cap'?: number; 'grpc-node.retry_max_attempts_limit'?: number; - 'grpc-node.http2_initial_window_size'?: number; + 'grpc-node.flow_control_window'?: number; // eslint-disable-next-line @typescript-eslint/no-explicit-any [key: string]: any; } diff --git a/packages/grpc-js/src/transport.ts b/packages/grpc-js/src/transport.ts index bb9257df..55862402 100644 --- a/packages/grpc-js/src/transport.ts +++ b/packages/grpc-js/src/transport.ts @@ -675,7 +675,7 @@ export class Http2SubchannelConnector implements SubchannelConnector { }, settings: { initialWindowSize: - options['grpc-node.http2_initial_window_size'] || + options['grpc-node.flow_control_window'] ?? http2.getDefaultSettings().initialWindowSize, } });