grpc
/
grpc-node
mirror of https://github.com/grpc/grpc-node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Check stream.session.socket before adding event handler

This commit is contained in:
murgatroid99 2019-09-06 13:21:47 -07:00
parent 4b4addf5b9
commit ae33497656
1 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
packages/grpc-js/src/call-stream.ts
View File

@ -342,14 +342,20 @@ export class Http2CallStream extends Duplex implements Call {
* from bubbling up. However, errors here should all correspond to
* "close" events, where we will handle the error more granularly */
});
/* If the underlying TLS or TCP connection closes, we want to end the
* call with an UNAVAILABLE status to match the behavior of the other
* library. In this handler we don't wait for trailers before ending the
* call. This should ensure that this endCall happens sooner than the one
* in the stream.on('close', ...) handler. */
stream.session.socket.on('close', () => {
this.endCall({code: Status.UNAVAILABLE, details: 'Connection dropped', metadata: new Metadata()});
});
/* For some reason, stream.session.socket can sometimes be undefined.
* When that happens trying to add this event handler throws an error.
* This check is a stopgap measure to get this working sometimes until
* we understand/eliminate those cases. */
if (stream.session.socket) {
/* If the underlying TLS or TCP connection closes, we want to end the
* call with an UNAVAILABLE status to match the behavior of the other
* library. In this handler we don't wait for trailers before ending the
* call. This should ensure that this endCall happens sooner than the one
* in the stream.on('close', ...) handler. */
stream.session.socket.on('close', () => {
this.endCall({code: Status.UNAVAILABLE, details: 'Connection dropped', metadata: new Metadata()});
});
}
if (!this.pendingRead) {
stream.pause();
}