grpc
/
grpc-node
mirror of https://github.com/grpc/grpc-node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Handle unauthorized TLS connections correctly

This commit is contained in:
Michael Lumish 2025-02-14 13:06:08 -08:00
parent bb6fff7ff5
commit b44b14d831
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/grpc-js/src/channel-credentials.ts
View File

@ -262,6 +262,10 @@ class SecureConnectorImpl implements SecureConnector {
}; };
return new Promise<SecureConnectResult>((resolve, reject) => { return new Promise<SecureConnectResult>((resolve, reject) => {
const tlsSocket = tlsConnect(tlsConnectOptions, () => { const tlsSocket = tlsConnect(tlsConnectOptions, () => {
if (!tlsSocket.authorized) {
reject(tlsSocket.authorizationError);
return;
}
resolve({ resolve({
socket: tlsSocket, socket: tlsSocket,
secure: true secure: true
@ -340,6 +344,10 @@ class CertificateProviderChannelCredentialsImpl extends ChannelCredentials {
...connnectionOptions ...connnectionOptions
} }
const tlsSocket = tlsConnect(tlsConnectOptions, () => { const tlsSocket = tlsConnect(tlsConnectOptions, () => {
if (!tlsSocket.authorized) {
reject(tlsSocket.authorizationError);
return;
}
resolve({ resolve({
socket: tlsSocket, socket: tlsSocket,
secure: true secure: true

4
packages/grpc-js/src/transport.ts
View File

@ -225,8 +225,8 @@ class Http2Transport implements Transport {
this.handleDisconnect(); this.handleDisconnect();
}); });
session.socket.once('close', () => { session.socket.once('close', (hadError) => {
this.trace('connection closed'); this.trace('connection closed. hadError=' + hadError);
this.handleDisconnect(); this.handleDisconnect();
}); });