From a58c178119642c07ba7276fc2846d79982b32ce3 Mon Sep 17 00:00:00 2001 From: Justin Beckwith Date: Fri, 9 Nov 2018 17:19:27 -0800 Subject: [PATCH] refactor: drop usage of _.isFunction --- packages/grpc-native-core/src/client.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/grpc-native-core/src/client.js b/packages/grpc-native-core/src/client.js index cc061c52..15de7b00 100644 --- a/packages/grpc-native-core/src/client.js +++ b/packages/grpc-native-core/src/client.js @@ -449,7 +449,7 @@ Client.prototype.resolveCallInterceptors = function(method_definition, intercept Client.prototype.makeUnaryRequest = function(path, serialize, deserialize, argument, metadata, options, callback) { - if (_.isFunction(options)) { + if (typeof options === 'function') { callback = options; if (metadata instanceof Metadata) { options = {}; @@ -457,7 +457,7 @@ Client.prototype.makeUnaryRequest = function(path, serialize, deserialize, options = metadata; metadata = new Metadata(); } - } else if (_.isFunction(metadata)) { + } else if (typeof metadata === 'function') { callback = metadata; metadata = new Metadata(); options = {}; @@ -470,7 +470,7 @@ Client.prototype.makeUnaryRequest = function(path, serialize, deserialize, } if (!((metadata instanceof Metadata) && (options instanceof Object) && - (_.isFunction(callback)))) { + (typeof callback === 'function'))) { throw new Error('Argument mismatch in makeUnaryRequest'); } @@ -552,7 +552,7 @@ Client.prototype.makeUnaryRequest = function(path, serialize, deserialize, Client.prototype.makeClientStreamRequest = function(path, serialize, deserialize, metadata, options, callback) { - if (_.isFunction(options)) { + if (typeof options === 'function') { callback = options; if (metadata instanceof Metadata) { options = {}; @@ -560,7 +560,7 @@ Client.prototype.makeClientStreamRequest = function(path, serialize, options = metadata; metadata = new Metadata(); } - } else if (_.isFunction(metadata)) { + } else if (typeof metadata === 'function') { callback = metadata; metadata = new Metadata(); options = {}; @@ -573,7 +573,7 @@ Client.prototype.makeClientStreamRequest = function(path, serialize, } if (!((metadata instanceof Metadata) && (options instanceof Object) && - (_.isFunction(callback)))) { + (typeof callback === 'function'))) { throw new Error('Argument mismatch in makeClientStreamRequest'); }