grpc
/
grpc-node
mirror of https://github.com/grpc/grpc-node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactor: use null instead of undefined to indicate that cleanupTimer is stopped

This commit is contained in:
Natan Sągol 2019-11-06 20:32:25 +01:00
parent 821c9ab494
commit e51a740216
No known key found for this signature in database
GPG Key ID: 891FD8B48DF1A5D4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/grpc-js/src/subchannel-pool.ts
View File

@ -40,7 +40,7 @@ export class SubchannelPool {
/**
* A timer of a task performing a periodic subchannel cleanup.
*/
private cleanupTimer: NodeJS.Timer | undefined;
private cleanupTimer: NodeJS.Timer | null;
/**
* A pool of subchannels use for making connections. Subchannels with the
@ -85,9 +85,9 @@ export class SubchannelPool {
* in significant memory usage we should change it. */
// Cancel the cleanup task if all subchannels have been unrefed.
if (allSubchannelsUnrefed && this.cleanupTimer !== undefined) {
if (allSubchannelsUnrefed && this.cleanupTimer !== null) {
clearInterval(this.cleanupTimer);
this.cleanupTimer = undefined;
this.cleanupTimer = null;
}
}
@ -95,7 +95,7 @@ export class SubchannelPool {
* Ensures that the cleanup task is spawned.
*/
ensureCleanupTask(): void {
if (this.global && this.cleanupTimer === undefined) {
if (this.global && this.cleanupTimer === null) {
this.cleanupTimer = setInterval(() => {
this.unrefUnusedSubchannels();
}, REF_CHECK_INTERVAL);