grpc
/
grpc-node
mirror of https://github.com/grpc/grpc-node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactor: drop usage of _.isFinite

This commit is contained in:
Justin Beckwith 2018-11-09 16:57:24 -08:00
parent 494b97ac1a
commit ea3e8e5997
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/grpc-native-core/src/client_interceptors.js
View File

@ -944,7 +944,7 @@ function _getClientStreamingInterceptor(method_definition, channel, emitter,
callback(e); callback(e);
return; return;
} }
if (_.isFinite(encoding)) { if (Number.isFinite(encoding)) {
/* Attach the encoding if it is a finite number. This is the closest we /* Attach the encoding if it is a finite number. This is the closest we
* can get to checking that it is valid flags */ * can get to checking that it is valid flags */
message.grpcWriteFlags = encoding; message.grpcWriteFlags = encoding;
@ -1145,7 +1145,7 @@ function _getBidiStreamingInterceptor(method_definition, channel, emitter) {
callback(e); callback(e);
return; return;
} }
if (_.isFinite(encoding)) { if (Number.isFinite(encoding)) {
/* Attach the encoding if it is a finite number. This is the closest we /* Attach the encoding if it is a finite number. This is the closest we
* can get to checking that it is valid flags */ * can get to checking that it is valid flags */
message.grpcWriteFlags = encoding; message.grpcWriteFlags = encoding;

2
packages/grpc-native-core/src/credentials.js
View File

@ -170,7 +170,7 @@ exports.createFromMetadataGenerator = function(metadata_generator) {
var message = ''; var message = '';
if (error) { if (error) {
message = error.message; message = error.message;
if (error.hasOwnProperty('code') && _.isFinite(error.code)) { if (error.hasOwnProperty('code') && Number.isFinite(error.code)) {
code = error.code; code = error.code;
} else { } else {
code = constants.status.UNAUTHENTICATED; code = constants.status.UNAUTHENTICATED;

2
packages/grpc-native-core/src/server.js
View File

@ -318,7 +318,7 @@ function _write(chunk, encoding, callback) {
(new Metadata())._getCoreRepresentation(); (new Metadata())._getCoreRepresentation();
this.call.metadataSent = true; this.call.metadataSent = true;
} }
if (_.isFinite(encoding)) { if (Number.isFinite(encoding)) {
/* Attach the encoding if it is a finite number. This is the closest we /* Attach the encoding if it is a finite number. This is the closest we
* can get to checking that it is valid flags */ * can get to checking that it is valid flags */
message.grpcWriteFlags = encoding; message.grpcWriteFlags = encoding;