grpc
/
grpc-node
mirror of https://github.com/grpc/grpc-node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make tests actually reflect expected behavior

This commit is contained in:
murgatroid99 2019-05-31 12:43:45 -07:00
parent c3041e8b9a
commit f2990d03ce
1 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
packages/grpc-native-core/test/surface_test.js
View File

@ -934,24 +934,7 @@ describe('Other conditions', function() {
call.write({}); call.write({});
call.end(); call.end();
}); });
it('client should wait for ready by default', function(done) { it('client should not wait for ready by default', function(done) {
this.timeout(15000);
const disconnectedClient = new Client('foo.test.google.com:50051', grpc.credentials.createInsecure());
const metadata = new grpc.Metadata({waitForReady: false});
const deadline = new Date();
deadline.setSeconds(deadline.getSeconds() + 10);
disconnectedClient.unary({}, metadata, {deadline: deadline}, (error, value) =>{
assert(error);
assert.strictEqual(error.code, grpc.status.DEADLINE_EXCEEDED);
done();
});
});
it('client should drop a call if not connected with waitForReady off', function(done) {
/* We have to wait for the client to reach the first connection timeout
* and go to TRANSIENT_FAILURE to confirm that the waitForReady option
* makes it end the call instead of continuing to try. A DNS resolution
* failure makes that transition very fast. */
this.timeout(15000); this.timeout(15000);
const disconnectedClient = new Client('foo.test.google.com:50051', grpc.credentials.createInsecure()); const disconnectedClient = new Client('foo.test.google.com:50051', grpc.credentials.createInsecure());
const metadata = new grpc.Metadata({waitForReady: false}); const metadata = new grpc.Metadata({waitForReady: false});
@ -962,6 +945,23 @@ describe('Other conditions', function() {
assert.strictEqual(error.code, grpc.status.UNAVAILABLE); assert.strictEqual(error.code, grpc.status.UNAVAILABLE);
done(); done();
}); });
});
it('client should wait for a connection with waitForReady on', function(done) {
/* We have to wait for the client to reach the first connection timeout
* and go to TRANSIENT_FAILURE to confirm that the waitForReady option
* makes it end the call instead of continuing to try. A DNS resolution
* failure makes that transition very fast. */
this.timeout(15000);
const disconnectedClient = new Client('foo.test.google.com:50051', grpc.credentials.createInsecure());
const metadata = new grpc.Metadata({waitForReady: true});
const deadline = new Date();
deadline.setSeconds(deadline.getSeconds() + 10);
disconnectedClient.unary({}, metadata, {deadline: deadline}, (error, value) =>{
assert(error);
assert.strictEqual(error.code, grpc.status.DEADLINE_EXCEEDED);
done();
});
}); });
describe('Server recieving bad input', function() { describe('Server recieving bad input', function() {
var misbehavingClient; var misbehavingClient;