grpc
/
grpc-node
mirror of https://github.com/grpc/grpc-node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1560 from grpc/revert-1556-master 

Revert "fix(grpc-js): Add support for impl type to server.addService"
This commit is contained in:
Michael Lumish 2020-09-02 16:04:42 -07:00 committed by GitHub
parent e21f3374e8 1fc284f59d
commit f2d3b4d1ed
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/grpc-js/src/server.ts
View File

@ -144,13 +144,9 @@ export class Server {
throw new Error('Not implemented. Use addService() instead');
}
addService<
ImplementationType extends {
[key: string]: any
}
>(
service: ServiceDefinition<ImplementationType>,
implementation: ImplementationType
addService(
service: ServiceDefinition,
implementation: UntypedServiceImplementation
): void {
if (this.started === true) {
throw new Error("Can't add a service to a started server.");

2
packages/grpc-js/test/test-server.ts
View File

@ -181,7 +181,7 @@ describe('Server', () => {
const server = new Server();
assert.throws(() => {
server.addService(({} as any), dummyImpls);
server.addService({}, dummyImpls);
}, /Cannot add an empty service to a server/);
});