grpc
/
grpc-node
mirror of https://github.com/grpc/grpc-node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #621 from JustinBeckwith/startsWith 

refactor: drop usage of _.startsWith
This commit is contained in:
Michael Lumish 2018-11-12 17:15:28 -08:00 committed by GitHub
parent 2ac78c17bf 261fb51ba9
commit f70eabb1ec
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/grpc-native-core/src/client.js
View File

@ -935,7 +935,7 @@ exports.makeClientConstructor = function(methods, serviceName,
ServiceClient.prototype.$method_names = {}; ServiceClient.prototype.$method_names = {};
_.each(methods, function(attrs, name) { _.each(methods, function(attrs, name) {
if (_.startsWith(name, '$')) { if (name.indexOf('$') === 0) {
throw new Error('Method names cannot start with $'); throw new Error('Method names cannot start with $');
} }
var method_type = common.getMethodType(attrs); var method_type = common.getMethodType(attrs);

4
packages/grpc-native-core/test/surface_test.js
View File

@ -489,8 +489,8 @@ describe('Echo metadata', function() {
var call = client.unary({}, metadata, var call = client.unary({}, metadata,
function(err, data) { assert.ifError(err); }); function(err, data) { assert.ifError(err); });
call.on('metadata', function(metadata) { call.on('metadata', function(metadata) {
assert(_.startsWith(metadata.get('user-agent')[0], assert.strictEqual(0,
'grpc-node/' + version)); metadata.get('user-agent')[0].indexOf('grpc-node/' + version));
done(); done();
}); });
}); });