Address review comments

This commit is contained in:
Michael Lumish 2024-03-13 15:16:42 -07:00
parent c3e9fbe538
commit f794b77934
2 changed files with 2 additions and 2 deletions

View File

@ -12,5 +12,5 @@ node server.js
## Start the client
```
GRPC_TRACE=transport,keepalive GRPC_VERBOSITY=DEBUG client.js
GRPC_TRACE=transport,keepalive GRPC_VERBOSITY=DEBUG node client.js
```

View File

@ -33,7 +33,7 @@ const packageDefinition = protoLoader.loadSync(
const echoProto = grpc.loadPackageDefinition(packageDefinition).grpc.examples.echo;
const keepaliveOptions = {
// Ping the client every 10 seconds to ensure the connection is still active
// Ping the server every 10 seconds to ensure the connection is still active
'grpc.keepalive_time_ms': 10_000,
// Wait 1 second for the ping ack before assuming the connection is dead
'grpc.keepalive_timeout_ms': 1_000,