Commit Graph

11 Commits

Author SHA1 Message Date
Dmitry Cheryasov 8f724121a2
Fix a TypeError loading a non-existent proto file.
The issue: https://github.com/grpc/grpc-node/issues/876

This is an obvious typo; `typeof` has to return a string `'undefined'`, not a literal `undefined.`
2019-05-20 15:36:15 -05:00
Michael Lumish 8e2e2b25c2
Merge branch 'master' into multi-filenames 2019-05-16 10:28:15 -07:00
cjihrig c5cc74e589
proto-loader: fix linting issues
This commit makes the linter pass for proto-loader.
2019-04-01 16:29:50 -04:00
cjihrig cbff0b4601
proto-loader: include Google well known protos
This commit ensures that the Google well known protos are
available because protobufjs only exposes a subset of them.
2019-04-01 16:29:26 -04:00
James Roper 7f85a775d6 Fixed load/loadSync filename parameter type
Fixes #805.

Changed the type of the filename parameter to the proto-loader load
method to match the type of the protobuf.js load method that it is
passed to.

Signed-off-by: James Roper <james@jazzy.id.au>
2019-03-29 16:03:51 +11:00
raunaqrox f9311fceca Fix typo in error message 2019-03-20 23:12:02 +05:30
raunaqrox 1d7ed8167a isArray instead of instanceof for consistent checking 2019-03-20 23:09:25 +05:30
murgatroid99 1a9e7cd7c7 Add message type information to package definition output. 2019-01-14 14:08:24 -08:00
murgatroid99 a6ecc7c8c8 proto loader: Fall back to default path resolution 2018-12-07 11:43:02 -08:00
Justin Beckwith 7e472e5bf4 refactor: use individual lodash package for proto loader 2018-11-09 16:39:03 -08:00
cjihrig 489305db79
proto-loader: rename grpc-protobufjs to match npm
This commit renames grpc-protobufjs to proto-loader to more
closely match the name used on npm.
2018-11-01 17:09:28 -04:00