Michael Lumish
f2dcb21a77
Merge branch 'master' into grpc-js-xds_server2
2024-07-01 11:19:12 -07:00
Michael Lumish
bac66ad291
grpc-js-xds: Implement xDS Server
2024-07-01 10:45:44 -07:00
Michael Lumish
d83355ba1c
Merge pull request #2782 from matthewbinshtok/binshtok/fix-validate-retry-config-error-msg
...
[grpc-js] Fix error messages in `serviceConfig` validation
2024-06-27 09:48:15 -07:00
gkampitakis
7f27b32245
resolve both ipv4 and ipv6
2024-06-27 13:32:40 +01:00
Matthew Binshtok
d6925d9141
fix tests
2024-06-26 14:17:03 -04:00
Michael Lumish
1faf6ced97
Merge pull request #2780 from aranjans/patch-1
...
xds_k8s_lb test: Increase the timeout
2024-06-26 10:03:08 -07:00
Matthew Binshtok
fc5bee791d
fix error msgs in service config validation
2024-06-26 10:15:30 -04:00
Abhishek Ranjan
65d8ef1b69
xds_k8s_lb test: Increase the timeout
...
Increased the timeout from 3hrs to 6hrs.
2024-06-26 12:17:28 +05:30
Michael Lumish
1e31c0f47f
Merge pull request #2770 from subhraOffGit/master
...
[vote]Added Active maintainers into MAINTAINERS.md.
2024-06-24 15:15:36 -07:00
Michael Lumish
f3aa040df3
Fix typo
2024-06-24 14:50:59 -07:00
Michael Lumish
c9342572aa
Merge pull request #2778 from murgatroid99/grpc-js_1.10.10
...
grpc-js: Bump to 1.10.10
2024-06-24 14:09:55 -07:00
Michael Lumish
3c55b5b7b5
Merge pull request #2777 from murgatroid99/grpc-js_1.10_backports
...
Backport #2746 and #2761 to 1.10.x
2024-06-24 10:59:09 -07:00
Michael Lumish
97c4cdac48
Merge pull request #2779 from murgatroid99/grpc-js_max_send_message_size_fix
...
grpc-js: Re-add client-side max send message size checking
2024-06-24 10:35:08 -07:00
Michael Lumish
42844cffd2
grpc-js: Re-add client-side max send message size checking
2024-06-20 13:15:12 -07:00
George Kampitakis
6278da6aec
support selecting resolver via env
2024-06-19 09:45:40 +01:00
George Kampitakis
c3d073b0cc
update per comments
2024-06-19 09:45:26 +01:00
Michael Lumish
cbab4e51cd
grpc-js: Bump to 1.10.10
2024-06-18 15:42:59 -07:00
Brendan Myers
5ae5514454
fix: add decoding for url encoded user credentials
2024-06-18 15:38:59 -07:00
James Watkins-Harvey
e759029532
HTTP CONNECT: handle early server packets
2024-06-18 15:38:45 -07:00
Michael Lumish
c447875796
Merge pull request #2761 from brendan-myers/url-encoding
...
fix: add decoding for url encoded user credentials
2024-06-18 15:36:48 -07:00
Michael Lumish
d90ca240fc
Merge pull request #2746 from mjameswh/http-connect-proxy-early-server-packet
...
HTTP CONNECT: handle early server packets
2024-06-18 15:36:28 -07:00
Michael Lumish
5c0226d0db
Merge pull request #2760 from davidfiala/@grpc/grpc-js@1.10.x
...
Keepalive bugfixes and unify timers strategies between client and server
2024-06-18 15:27:11 -07:00
Michael Lumish
52fe8e94e7
Merge pull request #2772 from murgatroid99/grpc-js_cardinality_error_hang
...
grpc-js: Fix client hang when receiving extra messages for a unary response
2024-06-18 15:25:59 -07:00
George Kampitakis
e2a93d188a
fix: support authority overrides in the DNS resolver
2024-06-18 18:41:47 +01:00
Michael Lumish
674f4e351a
Merge pull request from GHSA-7v5v-9h63-cj86
...
grpc-js: Avoid buffering significantly more than max_receive_message_size per received message
2024-06-10 10:33:47 -07:00
Michael Lumish
7ecaa2d2dc
grpc-js: Bump to 1.10.9
2024-06-07 10:52:50 -07:00
David Fiala
98cd87f751
ensure that client keepalive timers are always cleared when they trigger. this is a necessary change to fit with having removed keepaliveDisabled boolean. manually inspected test logs for both server.ts and transport.ts to verify both types of keepalives are operating correctly.
2024-06-06 22:57:13 -07:00
Michael Lumish
e64d816d7d
grpc-js: Avoid buffering significantly more than max_receive_message_size per received message (1.10.x)
2024-06-06 15:00:23 -07:00
David Fiala
3c5ab229b1
per discussion, avoid tracking keepalive disabled state and instead depend on whether the session is destroyed
2024-06-05 19:01:02 -07:00
Michael Lumish
7719e37c83
grpc-js: Fix client hang when receiving extra messages for a unary response
2024-06-05 17:55:56 -07:00
subhraOffGit
6957c6c4ec
[vote]Added Active maintainers into MAINTAINERS.md.
...
[vote] Added sergiitk, gnossen, temawi into grpc/node active maintainers list. Removed @jtattermusch, @nicolasnoble, @srini100 from active maintainers list and moved them to emeritus. Added @nimf to emeritus
Please comment as "Agree" if you agree to the change, if not please comment as "Disagree". Your comment will be counted as a vote.
The PR needs to stay open for 14 days, I.e. till 15th June 2024 as per governance guidelines
2024-06-01 20:28:10 +05:30
David Fiala
c2da436a8e
remove keepaliveDisabled from server.ts. rename keepaliveTimer.
2024-05-29 15:09:55 -07:00
David Fiala
a77d94f7c6
Based on grpc/grpc-node#2139 I wrapped http2session.ping in a try-catch block again
2024-05-29 10:37:40 -07:00
Brendan Myers
8e2dc274a3
fix: add decoding for url encoded user credentials
2024-05-29 19:24:48 +10:00
David Fiala
d325b5fff3
hoist in second location
2024-05-28 22:46:48 -07:00
David Fiala
bed5e85af9
resolve hoisting
2024-05-28 22:43:51 -07:00
David Fiala
19cdc1233c
another missing trace message for parity
2024-05-28 22:37:24 -07:00
David Fiala
7883164137
return imports back to original order
2024-05-28 22:35:40 -07:00
David Fiala
577b4b4748
add keepalive server trace back in to match channelz vs non-channelz trace behavior
2024-05-28 22:32:09 -07:00
David Fiala
d799a7a5bd
unify server and client keepalive matching comments and discussion on first round of review from https://github.com/grpc/grpc-node/pull/2760
2024-05-28 22:26:25 -07:00
David Fiala
334f0dcdb5
remove comment
2024-05-28 14:58:59 -07:00
Michael Lumish
a4c2106e63
Merge pull request #2758 from murgatroid99/grpc-js_1.10.x_upmerge
...
Merge 1.10.x branch into master
2024-05-28 14:58:13 -07:00
David Fiala
ad598ecbe4
Serverside keepalive error detection and cleanups
...
- Bugfix: Ensure that if session.ping returns false we correctly identify fail the keepalive and connection
- Bugfix: Ensure that if the interval between keepalives being sent occurs faster than the prior keepalive's timeout that we do not overwrite the reference to the prior timeout. Prior implementation could have in theory prevented a valid keepalive timeout from clearing itself. This rewrite keeps every timeout as a local (vs a shared state per session). Even if the timeout outlives the lifetime of a session, we still guard against errors by checking that the parent interval is not false-y. I reckon this could result in a short-term memory leak per session which is bounded for a maximum of keepaliveTimeoutMs. On the other hand even with that potential for a short reference hold, this implementation proposed here is more correct I think. One alternative we could do is keep a list of pending timeouts.. which is complex for a rare situation that will self resolve anyhow when keepaliveTimeoutMs is reached.
- Bug Fix: keepalive intervals were being cleared with an incorrect clearTimeout before. Not sure if this was causing intervals leaks in some nodejs impls or not. (v20.13.1 seems to accept this mismatch without issue)
- Rename variables for clarity, to prevent future bugs like swapping clearInterval vs clearTimeout.
- Implementation is repeated in two places, per warning from https://github.com/grpc/grpc-node/pull/2756#issuecomment-2136031256
- This commit supercedes the prior PR on a master branch which was out of date. https://github.com/grpc/grpc-node/pull/2756
2024-05-28 14:53:46 -07:00
Michael Lumish
71853407a4
Merge remote-tracking branch 'upstream/@grpc/grpc-js@1.10.x' into grpc-js_1.10.x_upmerge
2024-05-28 13:34:05 -07:00
Michael Lumish
45e5fe5462
Merge pull request #2750 from murgatroid99/grpc-js_idle_uds_fix
...
grpc-js: Fix UDS channels not reconnecting after going idle
2024-05-15 09:17:41 -07:00
Michael Lumish
87a3541402
grpc-js: Fix UDS channels not reconnecting after going idle
2024-05-14 14:47:53 -07:00
James Watkins-Harvey
3e89fdcec1
HTTP CONNECT: handle early server packets
2024-05-10 16:17:06 -04:00
Michael Lumish
3105791fbe
Merge pull request #2740 from sergiitk/backport-1.10-psm-interop-common-prod-tests
...
PSM Interop: simplify Kokoro buildscripts (@grpc/grpc-js@1.10.x backport)
2024-05-07 10:10:48 -07:00
Michael Lumish
fec135a980
Merge pull request #2729 from sergiitk/psm-interop-common-prod-tests
...
PSM Interop: simplify Kokoro buildscripts
2024-05-06 15:26:17 -07:00
Michael Lumish
15b7d4dcd4
Merge pull request #2729 from sergiitk/psm-interop-common-prod-tests
...
PSM Interop: simplify Kokoro buildscripts
2024-05-06 15:20:11 -07:00