Some clean-up on comments and instructions

This commit is contained in:
Stanley Cheung 2020-04-23 18:31:49 -07:00 committed by Stanley Cheung
parent 499f644a8b
commit 1dffd21b6a
3 changed files with 9 additions and 7 deletions

View File

@ -14,6 +14,9 @@
# limitations under the License.
set -ex
# This script is intended to be run with the base image from
# net/grpc/gateway/docker/prereqs/Dockerfile
cd /github/grpc-web/test/interop && \
npm install && \
npm link grpc-web

View File

@ -90,8 +90,8 @@ docker run --rm grpcweb/prereqs /bin/bash \
# Run interop tests
pid1=$(docker run -d -v $(pwd)/test/interop/envoy.yaml:/etc/envoy/envoy.yaml:ro \
--network=host -p 8080:8080 envoyproxy/envoy:v1.14.1)
pid2=$(docker run -d --network=host -p 7074:7074 grpcweb/node-interop-server)
--network=host envoyproxy/envoy:v1.14.1)
pid2=$(docker run -d --network=host grpcweb/node-interop-server)
docker run --network=host --rm grpcweb/prereqs /bin/bash \
/github/grpc-web/scripts/docker-run-interop-tests.sh

View File

@ -22,7 +22,7 @@ $ docker-compose -f advanced.yml build common prereqs node-interop-server intero
An interop server implemented in Node is hosted in the `grpc/grpc-node` repo.
```sh
$ docker run -d --network=host -p 7074:7074 grpcweb/node-interop-server
$ docker run -d --network=host grpcweb/node-interop-server
```
@ -33,7 +33,7 @@ tests.
```sh
$ docker run -d -v $(pwd)/test/interop/envoy.yaml:/etc/envoy/envoy.yaml:ro \
--network=host -p 8080:8080 envoyproxy/envoy:v1.14.1
--network=host envoyproxy/envoy:v1.14.1
```
@ -42,9 +42,8 @@ $ docker run -d -v $(pwd)/test/interop/envoy.yaml:/etc/envoy/envoy.yaml:ro \
You can either run the interop client as `npm test`, like this:
```sh
$ cd test/interop
$ npm install
$ npm test
$ docker run --network=host --rm grpcweb/prereqs /bin/bash \
/github/grpc-web/scripts/docker-run-interop-tests.sh
```
Or from the browser: