From 4974a7b5a98815113183f19298d9d9ffe93fbdad Mon Sep 17 00:00:00 2001 From: Eryu Xia Date: Fri, 30 Sep 2022 16:28:51 -0700 Subject: [PATCH] Expose getName() in MethodDescriptor and fix TS definitions. (#1289) --- javascript/net/grpc/web/methoddescriptor.js | 1 + packages/grpc-web/externs.js | 3 +++ packages/grpc-web/index.d.ts | 11 ----------- 3 files changed, 4 insertions(+), 11 deletions(-) diff --git a/javascript/net/grpc/web/methoddescriptor.js b/javascript/net/grpc/web/methoddescriptor.js index a4ff599..9f9fa5c 100644 --- a/javascript/net/grpc/web/methoddescriptor.js +++ b/javascript/net/grpc/web/methoddescriptor.js @@ -74,6 +74,7 @@ const MethodDescriptor = class { /** * @override + * @export */ getName() { return this.name; diff --git a/packages/grpc-web/externs.js b/packages/grpc-web/externs.js index a762da9..f7812da 100644 --- a/packages/grpc-web/externs.js +++ b/packages/grpc-web/externs.js @@ -32,3 +32,6 @@ module.UnaryResponse.prototype.getResponseMessage = function() {}; module.UnaryResponse.prototype.getMetadata = function() {}; module.UnaryResponse.prototype.getMethodDescriptor = function() {}; module.UnaryResponse.prototype.getStatus = function() {}; + +module.MethodDescriptor = function() {}; +module.MethodDescriptor.getName = function() {}; diff --git a/packages/grpc-web/index.d.ts b/packages/grpc-web/index.d.ts index 72c7218..09fb671 100644 --- a/packages/grpc-web/index.d.ts +++ b/packages/grpc-web/index.d.ts @@ -75,18 +75,7 @@ declare module "grpc-web" { responseType: new (...args: unknown[]) => RESP, requestSerializeFn: any, responseDeserializeFn: any); - createRequest(requestMessage: REQ, - metadata?: Metadata, - callOptions?: CallOptions): Request; - createUnaryResponse(responseMessage: RESP, - metadata?: Metadata, - status?: Status): UnaryResponse; getName(): string; - getMethodType(): string; - getRequestMessageCtor(): new (...args: unknown[]) => REQ; - getResponseMessageCtor(): new (...args: unknown[]) => RESP; - getRequestSerializeFn(): any; - getResponseDeserializeFn(): any; } export class Request {