grpc
/
grpc-web
mirror of https://github.com/grpc/grpc-web.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix code and documentation to pass `deadline` metadata as a String. (#1269) 

- As Metadata is a <string, string> map per Closure and TS definition.
This commit is contained in:
Eryu Xia 2022-08-30 16:08:35 -07:00 committed by GitHub
parent ccef7bd239
commit a5bd765d1d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -225,7 +225,7 @@ should be a Unix timestamp, in milliseconds.
var deadline = new Date(); var deadline = new Date();
deadline.setSeconds(deadline.getSeconds() + 1); deadline.setSeconds(deadline.getSeconds() + 1);
client.sayHelloAfterDelay(request, {deadline: deadline.getTime()}, client.sayHelloAfterDelay(request, {deadline: deadline.getTime().toString()},
(err, response) => { (err, response) => {
// err will be populated if the RPC exceeds the deadline // err will be populated if the RPC exceeds the deadline
... ...

4
javascript/net/grpc/web/grpcwebclientbase_test.js
View File

@ -84,8 +84,8 @@ testSuite({
deadline.setSeconds(deadline.getSeconds() + 1); deadline.setSeconds(deadline.getSeconds() + 1);
await new Promise((resolve, reject) => { await new Promise((resolve, reject) => {
client.rpcCall( client.rpcCall(
'url', new MockRequest(), {'deadline': deadline}, methodDescriptor, 'url', new MockRequest(), {'deadline': deadline.getTime().toString()},
(error, response) => { methodDescriptor, (error, response) => {
assertNull(error); assertNull(error);
resolve(); resolve();
}); });

6
test/interop/interop_client.js
View File

@ -52,8 +52,10 @@ function doEmptyUnary(done) {
function doEmptyUnaryWithDeadline(done) { function doEmptyUnaryWithDeadline(done) {
var testService = new TestServiceClient(SERVER_HOST, null, null); var testService = new TestServiceClient(SERVER_HOST, null, null);
const deadlineMs = 1000; // 1 second
testService.emptyCall(new Empty(), {deadline: Date.now() + deadlineMs}, const deadline = new Date();
deadline.setSeconds(deadline.getSeconds() + 1);
testService.emptyCall(new Empty(), {deadline: deadline.getTime().toString()},
(err, response) => { (err, response) => {
assert.ifError(err); assert.ifError(err);
assert(response instanceof Empty); assert(response instanceof Empty);