helm
/
helm
mirror of https://github.com/helm/helm.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(helm): fail when helm deps are not fetched 

This changes the behavior of the bulk downloader to fail as soon as it
encounters a dependency that it cannot fetch.

Closes #1439
This commit is contained in:
Matt Butcher 2016-10-26 16:54:20 -06:00
parent 5ea81b47b1
commit 5dfbf7e3cb
No known key found for this signature in database
GPG Key ID: DCD5F5E5EF32C345
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cmd/helm/downloader/manager.go
View File

@ -194,15 +194,15 @@ func (m *Manager) downloadAll(deps []*chartutil.Dependency) error {
for _, dep := range deps {
fmt.Fprintf(m.Out, "Downloading %s from repo %s\n", dep.Name, dep.Repository)
// Any failure to resolve/download a chart should fail:
// https://github.com/kubernetes/helm/issues/1439
churl, err := findChartURL(dep.Name, dep.Version, dep.Repository, repos)
if err != nil {
fmt.Fprintf(m.Out, "WARNING: %s (skipped)", err)
continue
return fmt.Errorf("could not find %s: %s", churl, err)
}
if _, _, err := dl.DownloadTo(churl, "", destPath); err != nil {
fmt.Fprintf(m.Out, "WARNING: Could not download %s: %s (skipped)", churl, err)
continue
return fmt.Errorf("could not download %s: %s", churl, err)
}
}
return nil