istio
/
api
mirror of https://github.com/istio/api.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[release-1.23] fix: ServiceEntryStatus (#3281) 

* update status to support 1 address per host rather than 1 address per service entry

Signed-off-by: ilrudie <ian.rudie@solo.io>

* release notes

Signed-off-by: ilrudie <ian.rudie@solo.io>

---------

Signed-off-by: ilrudie <ian.rudie@solo.io>
Co-authored-by: ilrudie <ian.rudie@solo.io>
This commit is contained in:
Istio Automation 2024-07-26 17:25:34 -04:00 committed by GitHub
parent 685739919a
commit 2e7f0011cd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 35 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
networking/v1alpha3/service_entry.pb.go generated
View File

@ -956,6 +956,8 @@ type ServiceEntryAddress struct {
// Value is the address (192.168.0.2)
Value string `protobuf:"bytes,1,opt,name=value,proto3" json:"value,omitempty"`
// Host is the name associated with this address
Host string `protobuf:"bytes,2,opt,name=host,proto3" json:"host,omitempty"`
}
func (x *ServiceEntryAddress) Reset() {
@ -997,6 +999,13 @@ func (x *ServiceEntryAddress) GetValue() string {
return ""
}
func (x *ServiceEntryAddress) GetHost() string {
if x != nil {
return x.Host
}
return ""
}
var File_networking_v1alpha3_service_entry_proto protoreflect.FileDescriptor
var file_networking_v1alpha3_service_entry_proto_rawDesc = []byte{
@ -1083,13 +1092,14 @@ var file_networking_v1alpha3_service_entry_proto_rawDesc = []byte{
0x69, 0x73, 0x74, 0x69, 0x6f, 0x2e, 0x6e, 0x65, 0x74, 0x77, 0x6f, 0x72, 0x6b, 0x69, 0x6e, 0x67,
0x2e, 0x76, 0x31, 0x61, 0x6c, 0x70, 0x68, 0x61, 0x33, 0x2e, 0x53, 0x65, 0x72, 0x76, 0x69, 0x63,
0x65, 0x45, 0x6e, 0x74, 0x72, 0x79, 0x41, 0x64, 0x64, 0x72, 0x65, 0x73, 0x73, 0x52, 0x09, 0x61,
0x64, 0x64, 0x72, 0x65, 0x73, 0x73, 0x65, 0x73, 0x22, 0x2b, 0x0a, 0x13, 0x53, 0x65, 0x72, 0x76,
0x64, 0x64, 0x72, 0x65, 0x73, 0x73, 0x65, 0x73, 0x22, 0x3f, 0x0a, 0x13, 0x53, 0x65, 0x72, 0x76,
0x69, 0x63, 0x65, 0x45, 0x6e, 0x74, 0x72, 0x79, 0x41, 0x64, 0x64, 0x72, 0x65, 0x73, 0x73, 0x12,
0x14, 0x0a, 0x05, 0x76, 0x61, 0x6c, 0x75, 0x65, 0x18, 0x01, 0x20, 0x01, 0x28, 0x09, 0x52, 0x05,
0x76, 0x61, 0x6c, 0x75, 0x65, 0x42, 0x22, 0x5a, 0x20, 0x69, 0x73, 0x74, 0x69, 0x6f, 0x2e, 0x69,
0x6f, 0x2f, 0x61, 0x70, 0x69, 0x2f, 0x6e, 0x65, 0x74, 0x77, 0x6f, 0x72, 0x6b, 0x69, 0x6e, 0x67,
0x2f, 0x76, 0x31, 0x61, 0x6c, 0x70, 0x68, 0x61, 0x33, 0x62, 0x06, 0x70, 0x72, 0x6f, 0x74, 0x6f,
0x33,
0x76, 0x61, 0x6c, 0x75, 0x65, 0x12, 0x12, 0x0a, 0x04, 0x68, 0x6f, 0x73, 0x74, 0x18, 0x02, 0x20,
0x01, 0x28, 0x09, 0x52, 0x04, 0x68, 0x6f, 0x73, 0x74, 0x42, 0x22, 0x5a, 0x20, 0x69, 0x73, 0x74,
0x69, 0x6f, 0x2e, 0x69, 0x6f, 0x2f, 0x61, 0x70, 0x69, 0x2f, 0x6e, 0x65, 0x74, 0x77, 0x6f, 0x72,
0x6b, 0x69, 0x6e, 0x67, 0x2f, 0x76, 0x31, 0x61, 0x6c, 0x70, 0x68, 0x61, 0x33, 0x62, 0x06, 0x70,
0x72, 0x6f, 0x74, 0x6f, 0x33,
}
var (

11
networking/v1alpha3/service_entry.pb.html generated
View File

@ -668,6 +668,17 @@ No
<td>
<p>Value is the address (192.168.0.2)</p>
</td>
<td>
No
</td>
</tr>
<tr id="ServiceEntryAddress-host">
<td><code>host</code></td>
<td><code>string</code></td>
<td>
<p>Host is the name associated with this address</p>
</td>
<td>
No

3
networking/v1alpha3/service_entry.proto
View File

@ -647,5 +647,8 @@ message ServiceEntryStatus {
message ServiceEntryAddress{
// Value is the address (192.168.0.2)
string value = 1;
// Host is the name associated with this address
string host = 2;
}

6
releasenotes/notes/3279.yaml Normal file
View File

@ -0,0 +1,6 @@
apiVersion: release-notes/v2
kind: bug-fix
area: traffic-management
releaseNotes:
- |
**Fixed** ServiceEntryStatus Addresses field could not easily support assigning IPs to each host which lead to an undesired divergence in behavior between the new and old implementations for automatic allocation of IP addresses for SericeEntry. Added a "Host" field to the Address in order to support mapping allocated IP to a host.