mark extraStatTags deprecated (#3037)

* mark extraStatTags deprecated

* release-notes

* fix gen

annotation/annotations.gen.go

@@ -462,7 +462,7 @@ var (
                         "present in this list.",
 		FeatureStatus: Alpha,
 		Hidden:        false,
-		Deprecated:    false,
+		Deprecated:    true,
 		Resources: []ResourceTypes{
 			Pod,
 		},

annotation/annotations.pb.html

@@ -146,9 +146,9 @@ Istio supports to control its behavior.
       <td>[Pod]</td>
       <td>Specifies whether or not an Envoy sidecar should enable core dump.</td>
     </tr>
-    <tr>
+    <tr class="deprecated">
       <td><code>sidecar.istio.io/extraStatTags</code></td>
-      <td>Alpha</td>
+      <td>Deprecated</td>
       <td>[Pod]</td>
       <td>An additional list of tags to extract from the in-proxy Istio Wasm telemetry. Each additional tag needs to be present in this list.</td>
     </tr>

annotation/annotations.yaml

@@ -476,7 +476,7 @@ annotations:
   - name: sidecar.istio.io/extraStatTags
     featureStatus: Alpha
     description: An additional list of tags to extract from the in-proxy Istio Wasm telemetry. Each additional tag needs to be present in this list.
-    deprecated: false
+    deprecated: true
     hidden: false
     resources:
       - Pod

mesh/v1alpha1/istio.mesh.v1alpha1.pb.html

@@ -2962,7 +2962,8 @@ No
 <p>An additional list of tags to extract from the in-proxy Istio telemetry. These extra tags can be
 added by configuring the telemetry extension. Each additional tag needs to be present in this list.
 Extra tags emitted by the telemetry extensions must be listed here so that they can be processed
-and exposed as Prometheus metrics.</p>
+and exposed as Prometheus metrics.
+Deprecated: <code>istio.stats</code> is a native filter now, this field is no longer needed.</p>
 
 </td>
 <td>

mesh/v1alpha1/proxy.pb.go

@@ -944,6 +944,7 @@ type ProxyConfig struct {
 	// added by configuring the telemetry extension. Each additional tag needs to be present in this list.
 	// Extra tags emitted by the telemetry extensions must be listed here so that they can be processed
 	// and exposed as Prometheus metrics.
+	// Deprecated: `istio.stats` is a native filter now, this field is no longer needed.
 	ExtraStatTags []string `protobuf:"bytes,27,rep,name=extra_stat_tags,json=extraStatTags,proto3" json:"extra_stat_tags,omitempty"`
 	// Topology encapsulates the configuration which describes where the proxy is
 	// located i.e. behind a (or N) trusted proxy (proxies) or directly exposed

mesh/v1alpha1/proxy.proto

@@ -510,6 +510,7 @@ message ProxyConfig {
   // added by configuring the telemetry extension. Each additional tag needs to be present in this list.
   // Extra tags emitted by the telemetry extensions must be listed here so that they can be processed
   // and exposed as Prometheus metrics.
+  // Deprecated: `istio.stats` is a native filter now, this field is no longer needed.
   repeated string extra_stat_tags = 27;
 
   // Topology encapsulates the configuration which describes where the proxy is

releasenotes/notes/deprecated-extrastattags.yaml

@@ -0,0 +1,6 @@
+apiVersion: release-notes/v2
+kind: feature
+area: telemetry
+releaseNotes:
+  - |
+    **Deprecated** extraStatTags in MeshConfig and annotations. This field will be removed in a future release.