We have this for CRD types, where it is strictly required to work with
k8s, but not for our other types. This makes it problematic to marshal
json for these types.
Note you can directly use protobuf json library, but this doesn't work
for nested types, hence the desire to have these. Low cost, some value.
We only generate this for some resources and not others, and no one has
complained -- so there doesn't seem to be much value in maintaining
this, but it provides a lot of boilerplate.
Rather than "fixing" it to be used for all types, seems better to just
drop this. We already have the schema as proto and OpenAPI (via CRD).
* Fix indentation of jwt doc
* Update comment line of jwtrule
* Fix indentation of jwt doc
* Update comment line of jwtrule
* Rebase with latest master
---------
Co-authored-by: Sathish Swaminathan <sathish.swaminathan@ibm.com>
Running make gen for some other change resulted in many additional
changes showing up in my local repo. So pushing a separate review for the same.
Signed-off-by: Faseela K <faseela.k@est.tech>
https://docs.buf.build/
Buf is the successor to https://github.com/uber/prototool which we
already use for linting.
This dramatically simplifies our Makefiles, which are both extremely
complicated and have led to numerous bugs historically, such as
https://github.com/istio/api/issues/1678.
This will make changes to the generation much simpler as well. For
example, to migrate to gogo protobuf, we will just need to change `gogo`
-> `go` in one location, rather than trying to wrangle 500 lines of
Makefiles. Additionally, its quite a bit faster - the whole proto stuff
is done in <1s now.
- Fix some broken dependency tracking.
- Remove a superfluous proto import to get rid of a warning.
- Explicitly select an older build-tools container version, since
the current one has some problems building the protos.
* Add openapi schema to Istio protos
* Update generated schema
* update output with the updated generator image
* Remove cue docker files as it is moved to tools repo
* Update json to current
* Update generated json with the latest change
* Update generation with latest changes
* remove some extra newlines in makefile
* Doc fixes.
* Add high-level overview and diagrams for MCP (#805)
* document MCP
* add additional note on NACK behavior
* add a note about ignoring stale nonces
* Add envoy metrics service configuration to ProxyConfig (#803)
* Add envoy metrics service configuration to ProxyConfig
Similar to the statsd sink config, this change is in preparation for adding support for the envoy metrics service API.
* Update proto.lock
* Reorder metrics_service_address just after statsd_udp_address
* Update comment in the authN API to match with 1.1 behavior (#808)
* Rename metrics_service_address to clarify that it is for Envoy's API (#809)
Since "metrics service" is so ambiguous, this change specifically denotes that the config is for Envoy's metrics service API. The comments also now link to detailed info about the metrics service API.
* Generate separate HTML page per proto under networking (#811)
* Generate separate pages for each networking proto
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
* update
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
* tweaks
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
* Fix interdoc references
* separate doc and go gen
* change dash to underscore
* fix
* more fixes
* makefile fix
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
* remove bad target
* Revert "change dash to underscore"
This reverts commit 7fbced66f6.
* final update
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
* Revert "Generate separate HTML page per proto under networking (#811)"
This reverts commit 5f14eadd since it breaks the ability
to generate reference docs in istio.io
* Update to latest tools.
* Revert "Update to latest tools."
This reverts commit 231fadc5 which I accidentally pushed to the
wrong place.
* fix mcp update error diagram (#810)
* update istio/tools (#815)
* Revert "Revert "Generate separate HTML page per proto under networking (#811)"" (#818)
* Minor updates for building docker images. (#817)
* Add spell checking for docs. (#819)
* Add a bunch of words to the custom dictionary.
* Document exportTo restrictions (#820)
* Doc fixes. (#821)
* Proxy config: Add tls_certs_to_watch field (#824)
* Proxy config: Add tls_certs_to_watch field
* Address PR comment
* Revert "Proxy config: Add tls_certs_to_watch field (#824)" (#825)
This reverts commit e613e358ae.
* Update gateway and sidecar hosts doc (#826)
* Update gateway and sidecar hosts doc
* regen
* review comments
* Update API docs (service entry, gateway, sidecar) (#831)
* Update sidecar and gateway docs
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
* gen docs
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
* update service entry
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
* updates
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
* add configurable dns refresh rate to mesh for strict dns cluster, (#832)
* add configurable dns refresh rate to mesh for strict dns cluster, issue #12181
* add lock file
* Post-merge generation
* assorted doc updates (#757)
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
* add optional incremental flag to ResponseSink and ResourceSource services (#762)
* Add option to select worload using lables for authn policy. (#755)
* Add option to select workload using labels for authn policy
* Make proto-commit
* Introduce forward looking MCP enhancements
The initial version of Mesh Configuration Protocol (MCP) was
introduced to decouple Pilot/Mixer from the k8s kube-apiserver. These
enhancements address additional forward looking requirements as we
bring Galley and the MCP API to beta quality.
* Enable alternative control topologies where the source of
configuration is not publicly accessible.
* Provide a feedback mechanism to report the observed config state to
the user (e.g via CRD status).
* Improve performance at scale (e.g. Enterprise use case)
* Rationalize the resource model
The intent is to introduce these backwards incompatible API changes
now before Galley and MCP ship as beta quality and on-by-default.
Rationalization of the resource model and incremental improvements can
be implemented immediately as they effect the contract between Pilot
and Galley. Alternative control topologies and feedback/status are
inherently new features and can be implemented later with the same
APIs without concerns of breaking compatibility.
Design proposal: https://goo.gl/RTKMwF
* fix linter error
* add missing generated file
* proto-commit
* remove python/istio_api/mcp/v1alpha1/envelope_pb2.py
* s/envelope/resource
* s/client/node
* make proto-commit
* fix comments
* add system_version_info for compatibility with non-incremental MCP
* address review comments
* s/node/sink_node
* address more review comments
* update resource name documentation
* add incremental mcp based on incremental xds
Extend the MCP to include support for incremental configuration
pushes. This is *heavily* derived from the new incremental xDS
protocol.
xref: https://github.com/envoyproxy/data-plane-api/blob/master/XDS_PROTOCOL.md#incremental-xds
* document initial_resource_versions should only be included in first request
* move resource version into metadata
jacob-delgado