int64 in proto is encoded to json as a string. To support this, we make
it accept either form.
Without this, istio fails to write the status. See
https://github.com/istio/istio/pull/52159.
Note: this is only an issue now since we just added schema validation
for status.
* addressing late comments from 3244
Signed-off-by: ilrudie <ilrudie@gmail.com>
* adding an istio-status-override comment so tools may override the status without hardcoding
Signed-off-by: ilrudie <ilrudie@gmail.com>
* fix spelling
Signed-off-by: ilrudie <ilrudie@gmail.com>
* move status comment to a location where it can be consumed
Signed-off-by: ilrudie <ian.rudie@solo.io>
---------
Signed-off-by: ilrudie <ilrudie@gmail.com>
Signed-off-by: ilrudie <ian.rudie@solo.io>
We only generate this for some resources and not others, and no one has
complained -- so there doesn't seem to be much value in maintaining
this, but it provides a lot of boilerplate.
Rather than "fixing" it to be used for all types, seems better to just
drop this. We already have the schema as proto and OpenAPI (via CRD).
* Fix indentation of jwt doc
* Update comment line of jwtrule
* Fix indentation of jwt doc
* Update comment line of jwtrule
* Rebase with latest master
---------
Co-authored-by: Sathish Swaminathan <sathish.swaminathan@ibm.com>
* Add proto for analysis messages
* Add analysis protos to make system
* Better comments, clearer intention with code/name
* Move analysis to beta, add meta types
* update ValidationMessages to validation_messages
* more snake casing, hopefully doesnt break kubernetes compatibility
* try to get all generated files updated
* update gen conflicts after rebase
* move analysis back to alpha
* demote meta to v1alpha1
* remove remnants of beta apis
* resolve gen problems related to demotion
Co-authored-by: Clayton Pence <ctpence@google.com>