Previously, only a Gateway resource was defined as a supported
attachment type. This PR updates the API docs to include a Service
as a supported type and also fixes an incorrect link to Gateway API
documentation.
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
* Allow defining CRDs from a single version
Part of https://github.com/istio/api/issues/3127. Goes with a
corresponding tools change; this will fail until that merges.
This just shows DR. The tool will support both the new and old way (we
can remove the old way if we want), so we don't have to move everything
at once. We will, though. I kept it to one so its easy to review first.
* Move all APIs over
This is the only API we have a `selector` without `targetRef`.
The motivation at the time was that waypoints don't official support
EnvoyFilter, and targetRef was primarily for waypoints.
However, targetRef can be used with all Kubernetes Gateway, including
for ingress, where EnvoyFilter is supported. Also, long term it will
support waypoint as well I assume; the earlier we add the field the less
migration pain there is.
This PR goes directly to `targetRefs` in line with
https://github.com/istio/api/pull/3159.
* support file mounted CRL
Signed-off-by: Faseela K <faseela.k@est.tech>
* review comments
Signed-off-by: Faseela K <faseela.k@est.tech>
* enhance description of the field based on Lin's comments
Signed-off-by: Faseela K <faseela.k@est.tech>
---------
Signed-off-by: Faseela K <faseela.k@est.tech>
* Add idle_timeout to DestinationRule.TcpSettings
Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
* Add release note
Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
* Clarify that idle_timeout does not work for weighted clusters
Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
* Describe idle_timeout in more detail
Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
* Add suggested change
Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
---------
Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
* fix an incorrect statement
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
* adding the generated files
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
---------
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
* Add support for default and per-port connection pool settings for inbound connections to Envoy sidecars
* flesh out comments on connection pool and describe how they relate to destinationrule. Add a release note for the new field.
* missed comments in v1beta1 that should've been in v1alpha1
The `REQUIRED` proto label currently does nothing. As a result, some of
them are misaligned with reality -- fields marked REQUIRED are actually
not required, and often even have valid behaviors and are used in the
real world.
Unfortunately, many of these are fields that *should* be required but
are not. To maintain backwards compatibility, these cannot be made
required at this point, sadly.
In a future PR, I intend to make `REQUIRED` *actually make it required*,
so this PR is a pre-requisite to doing that.
We only generate this for some resources and not others, and no one has
complained -- so there doesn't seem to be much value in maintaining
this, but it provides a lot of boilerplate.
Rather than "fixing" it to be used for all types, seems better to just
drop this. We already have the schema as proto and OpenAPI (via CRD).
* change page
* changes for docs to sync the needed ones
* fix tabset error
* fix spacing issue
* add checks to sync.sh to ensure mode is set
* fix changes from merge
* fix missing tabset
* fix tabset again
Jacob Delgado