For https://github.com/istio/istio/pull/48449
Why a top level field instead of a value? This allows a consistent UX
for users of helm or istioctl. This makes it easier to document,
especially in istioctl precheck: `install with --set compatibilityVersion=1.20 to retain the old default.`
* Fix indentation of jwt doc
* Update comment line of jwtrule
* Fix indentation of jwt doc
* Update comment line of jwtrule
* Rebase with latest master
---------
Co-authored-by: Sathish Swaminathan <sathish.swaminathan@ibm.com>
Running make gen for some other change resulted in many additional
changes showing up in my local repo. So pushing a separate review for the same.
Signed-off-by: Faseela K <faseela.k@est.tech>
* operator: use camelCase
operator relies on merging using K8s libraries. K8s libraries use the
`json` tag. protobuf doesn't have a way to configure this (`json_tag` is
for `protobuf.json`, not `json`) and never will.
JSON tag comes from the protobuf name. So we can make it camelCase to
fix the above issue. This will have no impact on unmarshalling with jsonpb -- which we use in
all cases aside from the merging -- any casing is allowed.
This may be a breaking change in the protobuf sense (but NOT to Istio
users), but it doesn't really matter as until last week the operator
protobuf was not a real protobuf at all and relied on `sed` to make it
into the shape we want. Therefor, its not possible someone depended on
the operator protobuf being protobuf-compatible.
* add comment
* gen
* extra line
* comment
* gen
https://docs.buf.build/
Buf is the successor to https://github.com/uber/prototool which we
already use for linting.
This dramatically simplifies our Makefiles, which are both extremely
complicated and have led to numerous bugs historically, such as
https://github.com/istio/api/issues/1678.
This will make changes to the generation much simpler as well. For
example, to migrate to gogo protobuf, we will just need to change `gogo`
-> `go` in one location, rather than trying to wrangle 500 lines of
Makefiles. Additionally, its quite a bit faster - the whole proto stuff
is done in <1s now.
* Fix quantity and lock down others to correct IntOrString
Signed-off-by: Liam White <liam@tetrate.io>
* fix imports
Signed-off-by: Liam White <liam@tetrate.io>
* Consolidate opeator API to one file to maintain field order
* Mirror Tolerations
* Remove json gen
* Rebuild
* Restore deepcopy
* Remove unneeded sed
* Rebuild
* Lint
* Update releaselocks
* Move deepcopy from autogenerated path
* Copyright banner
* Gofmt
Jacob Delgado