Upgrade tool versions. (#5860)

Makefile.core.mk

@@ -34,16 +34,16 @@ serve: gen
 netlify_install:
 	@npm init -y
 	@npm install --production --global \
-	    sass@v1.22.10 \
-	    typescript@v3.5.3 \
+	    sass@v1.23.7 \
+	    typescript@v3.7.2 \
 	    svgstore-cli@v1.3.1 \
-		@babel/core@v7.5.5 \
-		@babel/cli@v7.5.5 \
-		@babel/preset-env@v7.5.5
+		@babel/core@v7.7.4 \
+		@babel/cli@v7.7.4 \
+		@babel/preset-env@v7.7.4
 	@npm install --production --save-dev \
 		babel-preset-minify@v0.5.1
 	@npm install --save-dev \
-		@babel/polyfill@v7.4.4
+		@babel/polyfill@v7.7.0
 
 netlify: netlify_install
 	@scripts/gen_site.sh

netlify.toml

@@ -2,6 +2,6 @@
     publish = "public"
 
 [build.environment]
-    HUGO_VERSION = "0.58.2"
+    HUGO_VERSION = "0.59.1"
     NODE_VERSION = "12.8.0"
     BUILD_WITH_CONTAINER = "0"

scripts/gen_site.sh

@@ -22,12 +22,7 @@ sass src/sass/_all.scss all.css -s compressed --no-source-map
 mv all.css* generated/css
 tsc
 
-# TODO: We should be passing the `--presets minify` option to Babel for optimal results in both cases below,
-#       but this just started to fail in Netlify with non-sense errors on 2019/11/05,
-#       even though all tool and library versions are pinned. So I'm turning this off for
-#       now. We can try turning it back on later and see what happens.
-
-babel --source-maps --minified --no-comments \
+babel --source-maps --minified --no-comments --presets minify \
   tmp/js/constants.js \
   tmp/js/utils.js \
   tmp/js/feedback.js \

src/ts/sidebar.ts

@@ -83,7 +83,7 @@ function handleSidebar(): void {
             body.style.maxHeight = body.scrollHeight + "px";
         } else {
             // if was expanded, reset this
-            body.style.maxHeight = null;
+            body.style.maxHeight = "";
         }
     }