From b2a72e0ae252602c11d321541f35ba5df5f02842 Mon Sep 17 00:00:00 2001 From: Douglas Reid Date: Wed, 13 May 2020 13:09:55 -0700 Subject: [PATCH] Fix classify docs (#7290) * fix(classify-metrics): remove problematic config * add extra bit for catching config errors --- .../tasks/observability/metrics/classify-metrics/index.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content/en/docs/tasks/observability/metrics/classify-metrics/index.md b/content/en/docs/tasks/observability/metrics/classify-metrics/index.md index a59480169c..d0a2177d96 100644 --- a/content/en/docs/tasks/observability/metrics/classify-metrics/index.md +++ b/content/en/docs/tasks/observability/metrics/classify-metrics/index.md @@ -295,7 +295,7 @@ spec: { "name": "requests_total", "dimensions": { - "response_code": "has(istio_responseClass)?istio_responseClass:response.code" + "response_code": "istio_responseClass" } }] } @@ -327,7 +327,7 @@ If classification does not occur as expected, check the following potential caus Review the Envoy proxy logs for the pod that has the service on which you applied the configuration change. Check that there are no errors reported by the service in the Envoy proxy logs on the pod, (`pod-name`), where you configured classification by using the following command: {{< text bash >}} -$ kubectl log pod-name -c istio-proxy | grep "Config Error" +$ kubectl log pod-name -c istio-proxy | grep -e "Config Error" -e "envoy wasm" {{< /text >}} Additionally, ensure that there are no Envoy proxy crashes by looking for signs of restarts in the output of the following command: