[external-control-plane] - Use uniform mode for ingress/egress install (#15669)

* [external-control-plane] - Use istioctl for both ingress/egress installation

Signed-off-by: Faseela K <faseela.k@est.tech>

* fix test

Signed-off-by: Faseela K <faseela.k@est.tech>

* use istioctl install

Signed-off-by: Faseela K <faseela.k@est.tech>

* use istioctl install

Signed-off-by: Faseela K <faseela.k@est.tech>

---------

Signed-off-by: Faseela K <faseela.k@est.tech>

content/en/docs/setup/install/external-controlplane/index.md

@@ -540,6 +540,8 @@ Enable an ingress gateway on the remote cluster:
 $ cat <<EOF > istio-ingressgateway.yaml
 apiVersion: install.istio.io/v1alpha1
 kind: IstioOperator
+metadata:
+  name: ingress-install
 spec:
   profile: empty
   components:
@@ -565,8 +567,8 @@ $ helm install istio-ingressgateway istio/gateway -n external-istiod --kube-cont
 
 See [Installing Gateways](/docs/setup/additional-setup/gateway/) for in-depth documentation on gateway installation.
 
-    {{< /tab >}}
-    {{< /tabset >}}
+{{< /tab >}}
+{{< /tabset >}}
 
 You can optionally enable other gateways as well. For example, an egress gateway:
 
@@ -578,6 +580,8 @@ You can optionally enable other gateways as well. For example, an egress gateway
 $ cat <<EOF > istio-egressgateway.yaml
 apiVersion: install.istio.io/v1alpha1
 kind: IstioOperator
+metadata:
+  name: egress-install
 spec:
   profile: empty
   components:

content/en/docs/setup/install/external-controlplane/snips.sh

@@ -358,6 +358,8 @@ snip_enable_gateways_1() {
 cat <<EOF > istio-ingressgateway.yaml
 apiVersion: install.istio.io/v1alpha1
 kind: IstioOperator
+metadata:
+  name: ingress-install
 spec:
   profile: empty
   components:
@@ -381,6 +383,8 @@ snip_enable_gateways_3() {
 cat <<EOF > istio-egressgateway.yaml
 apiVersion: install.istio.io/v1alpha1
 kind: IstioOperator
+metadata:
+  name: egress-install
 spec:
   profile: empty
   components:

content/en/docs/setup/install/external-controlplane/test.sh

@@ -53,10 +53,7 @@ snip_set_up_a_gateway_in_the_external_cluster_6
 
 snip_get_remote_config_cluster_iop
 snip_set_up_the_remote_config_cluster_2
-
-#set +e #ignore failures here
 echo y | snip_set_up_the_remote_config_cluster_3
-#set -e
 
 _verify_like snip_set_up_the_remote_config_cluster_4 "$snip_set_up_the_remote_config_cluster_4_out"
 
@@ -95,11 +92,11 @@ _verify_like snip_deploy_a_sample_application_3 "$snip_deploy_a_sample_applicati
 _verify_contains snip_deploy_a_sample_application_4 "Hello version: v1"
 
 if [ "$GATEWAY_API" != "true" ]; then
-  # Install ingress with istioctl
+  # Install ingress gateway
   echo y | snip_enable_gateways_1
 
-  # And egress with helm
-  _rewrite_helm_repo snip_enable_gateways_4
+  # Install egress gateway
+  echo y | snip_enable_gateways_3
 
   _verify_same kubectl_get_egress_gateway_for_remote_cluster "Running"
 fi