This has proven to cause constant merge conflicts and decrease
contribution experience. We went through the same issue in the
environments WG and got rid of these types of generated codes which just
lead to constant conflicts.
If we do really want this, we should move it to something generated on
the fly in the build and not checked in.
* Update reference docs - remove metrics items
* Fix links
* Actually fix links
* Fix make gen
* Early change from https://github.com/istio/api/pull/1617
* Review comments and rebase
* automated test for viewing traces from zipkin dashboard (expectation is that traces are seen correctly)
* fix shellcheck linting errors
* remove verification of traces and just check if zipkin dashboard is accessible through port-forward
* Modify snippet generation logic to take {{< boilerplate >}} into account
* snippets for boilerplate
* fix shellcheck (linting) issues
* snippets generated with new logic
* automated test - check if zipkin dashboard is accessible by port-forwarding (as we cannot verify screenshot and the trace is already verified in istio/istio integration test
* clean up ZIPKIN_URL comment
* Address code review comments
1. Simplify boilerplate snippet filenames (remove .md_snips)
2. Sourced filenames should be in double quote(") instead of single quote(')
* fix gencheck_istio flake
* do not generate or include boilerplate snippets if there is not {{<text>}} in them
* fix linting errors in snip.py
* fix bug - filter out boilerplates without snippets very early
* Update grab_reference_docs to also strip `latest` from url
* Update scripts/grab_reference_docs.sh
Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>
Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>
* Updated site to build archived packages at istio.io/{version} (#7515)
* cache sidebar smartly when building site (#7431)
* change archive process to include static archives every build
* fix zh redirects (#7523)
* fix redirects for vanity imports (#7524)
* fix 1.1 and 1.2 links (#7526)
* fix links in 1.3 and 1.4
* snip.py: Replace github file token with release-specific URL.
* verify.sh: Show the expected output as well as the actual output.
* snip.py: Update the githubfile regex to not include email addresses.
When generating snip scripts, pairs of "@" signs indicate a link to
GitHub repo content. However, JWT attribute values contained pairs of
email addresses such as:
`testing@secure.istio.io/testing@secure.istio.io`
which would be treated as an email address and mangled. This commit
rewrites the regex to not match on email addresses.
* Add authz-jwt user guide test.
* Update lint to only check languages for files in current PR
* Default branch to master if undefined, lint fixes
* Fix @ in Makefile.core.mk
* Add pt-br support to language check
* Review comments
* Apply suggestions from code review
Either BRANCH is specified or a language, else it fails.
Co-Authored-By: Frank Budinsky <frankb@ca.ibm.com>
* Update scripts/lint_site.sh
Co-Authored-By: Frank Budinsky <frankb@ca.ibm.com>
* Update Makefile.core.mk
Co-Authored-By: Frank Budinsky <frankb@ca.ibm.com>
* Don't check languages for lint-fast if no languages are found
Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>
Reverted the actual mirror test script, because mirror test seems to have some subtle failure when running with what seems to be the exact same commands via snips. Will investigate further in followup PR. Merging this one to get the generator changes.
* Retire helm documentation as we use a protobuf
The new rendered source of truth is:
https://preliminary.istio.io/docs/reference/config/istio.operator.v1alpha1/
This is rendered from the API repo protobuf which (may) need description fields
set. That protobuf is here:
https://github.com/istio/api/blob/master/operator/v1alpha1/operator.proto
* Follow the flowchart
The flowchart is not quite right and could use some improvement.
* Update content/en/blog/2019/performance-best-practices/index.md
Co-Authored-By: Frank Budinsky <frankb@ca.ibm.com>
Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>
* Update doc test README
* add sh
* tweaks
* formatting
* format
* fix comment
* wording
* convert mtls migration task
* Update tests/README.md
Co-Authored-By: Eric Van Norman <ericvn@us.ibm.com>
* Update tests/README.md
Co-Authored-By: Eric Van Norman <ericvn@us.ibm.com>
Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>
* Make site linter more configurable
* change brittle github links error to warning
* turn off external link checking by default
* update makefile
* fix target lint
* remove cross language link
* better variable name