The regex was @.*@ which will match anything between two @'s, including a command like:
`k3d cluster create --api-port 6550 -p '9080:80@loadbalancer' -p '9443:443@loadbalancer' --agents 2 --k3s-arg '--disable=traefik@server:*'`
The regex should be something that matches valid URL syntaxes.
Signed-off-by: Daniel Hawton <daniel.hawton@solo.io>
* Re-enable processing of gateway-api version in `make gen`
* Update gateway-api to be the publicly released base version
* remove script and add awk in Makefile
* rebase and make gen
* remove injected annotation for istio-cni
* add injector webhook config back, add tip about it overwriting existing configs
* update docs with istio_cni.chained installation config
* update helm install instructions
* fix linting
* pass linter
* clarify tip for previous Openshift users to be aware that the injection webhook is not required
* update per PR suggestion
* generate new snips
* update cni docs by removing tip and adding openshift install command per PR
* lint fix
---------
Co-authored-by: Jacob Delgado <jacob.delgado@volunteers.acasi.info>
* Change Istio Classic terminology to Istio APIs
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
* Fix stutter
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
* Change back parallel structure formation
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
---------
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
* Master has a non release gateway API. Changes to allow that.
* Grab a istio test ref from main branch
* <ove from istio.io/pkg to istio/istio/pkg
* revert one change
* update istio/api
* Run make gen
* disable failing test temporarily
* generic-args-md
* create generic boilerplates/args.md
* include gw_api_version, full_version, previous_version
* update install/operator/test.sh to source and use new vars
* update test/util/gateway-api.sh to source and use new gw var
* remove gateway-api-version.md
* relates to #13085
* fix linting fail for args.md
* remove sed command for revision string, use param expansion
* Enable tests for operator install
* install-operator-tests
* update snip_id
* set snip_id=none for non-tested snips
* add test scenarios for helm,watchns,install istio,update
* use functions for better readability
* add newline at the end
* install-operator-tests
* add tests for inplace and canary upgrade
* update version 1.8.1 and 1.9.0 to 1.17.1 and 1.17.2 in docs
* disable snip remove_operator failing lint/test
* install-operator-tests
* remove all hardcoded versions in operator install doc
* add istio_previous_version and full/previous revision to snip.py
* adjust test.sh accordingly
* install-operator-tests
* add shorcodes for revision versions
* install-operator-tests
* fix canary upgrade (upgrade from previous to full version)
* install-operator-tests
* fix reference to full_version in canary upgrade
* install-operator-tests
* fix slightly off format
* install-operator-tests
* disable test for upgrade with helm tip
* add instructions to doc for canary upgrade prep
* update test.sh and snips.sh accordingly
* install-operator-tests
* fix profile on upgrade, use default
Before the Deployment was kept as minimal as possible. This is mostly
good, because users can set any Deployment settings and things work.
However, running as non-root is a bit quirky, and very very strongly
recommended, so I think its worth calling out here.
This is one of the #1 sources of confusion we get.
* remove explicit istio-injection labeling on ns for ingress-gateway
The gateway deployment already has the annotation "sidecar.istio.io/inject=true"
Signed-off-by: Faseela K <faseela.k@est.tech>
* fix lint
Signed-off-by: Faseela K <faseela.k@est.tech>
* fix lint
Signed-off-by: Faseela K <faseela.k@est.tech>
---------
Signed-off-by: Faseela K <faseela.k@est.tech>
* build an archive of v1.16 in master
* update data/versions.yml and archive index page
* advance master to release-1.18
* Fix lint by moving back to older files - Note automated job will fail lint.
* Temporarily disable the istioctl-analyze test
* Clarify gateway canary upgrade
Signed-off-by: Faseela K <faseela.k@est.tech>
* Apply suggestions from code review
Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>
* Update index.md
---------
Signed-off-by: Faseela K <faseela.k@est.tech>
Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>
* Enhance docs for revision tags and add tests
Signed-off-by: Faseela K <faseela.k@est.tech>
* Fix test failures
Signed-off-by: Faseela K <faseela.k@est.tech>
* Fix lint failure
Signed-off-by: Faseela K <faseela.k@est.tech>
* Fix test failures
Signed-off-by: Faseela K <faseela.k@est.tech>
* Fix cleanup test failures
Signed-off-by: Faseela K <faseela.k@est.tech>
* Fix cleanup for canary upgrade tests
Signed-off-by: Faseela K <faseela.k@est.tech>
* add profile none
Signed-off-by: Faseela K <faseela.k@est.tech>
* review comments
Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>
* make gen
Signed-off-by: Faseela K <faseela.k@est.tech>
Signed-off-by: Faseela K <faseela.k@est.tech>
Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>
* Doc for installing multiple control planes using revisions and discoverySelectors
Signed-off-by: Faseela K <faseela.k@est.tech>
* make gen
Signed-off-by: Faseela K <faseela.k@est.tech>
* Fix test
Signed-off-by: Faseela K <faseela.k@est.tech>
* enable peer-auth
Signed-off-by: Faseela K <faseela.k@est.tech>
* Fix test
Signed-off-by: Faseela K <faseela.k@est.tech>
* Review comments
Signed-off-by: Faseela K <faseela.k@est.tech>
* More review comments
Signed-off-by: Faseela K <faseela.k@est.tech>
* Additional review comments
Signed-off-by: Faseela K <faseela.k@est.tech>
* Review comments
Signed-off-by: Faseela K <faseela.k@est.tech>
* Apply suggestions from code review
Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>
* Remove duplicates that came from commit suggestion
* Rerun make gen
Signed-off-by: Faseela K <faseela.k@est.tech>
Signed-off-by: Faseela K <faseela.k@est.tech>
Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>
Fix linting issues
./en/docs/setup/platform-setup/gardener/index.md:15: MD009 Trailing spaces
./en/docs/setup/platform-setup/gardener/index.md:72: MD009 Trailing spaces
Fix linter identified typos
19 | ternatively, [23 Technologies GmbH](https://23technologies.cloud
19 | managed Gardener service that conviniently works with all supported clou
19 | and comes with a free trial: [Okeanos](https://okeanos.dev/). Simil
19 | ACKIT](https://stackit.de/), [B'Nerd](https://bnerd.com/), [MetalS
19 | B'Nerd](https://bnerd.com/), [MetalStack](https://metalstack.cloud/),
21 | log/2018/05/17/gardener/) on [kubernetes.io](https://kubernetes.io/blog).
resolve with recommendations from istio team
incorporate feedback from @ericvn and cleanup
* to be clear with how to apply custom metrics
Signed-off-by: oops-oom <734819342@qq.com>
* fix test error
Signed-off-by: oops-oom <734819342@qq.com>
* fix for test
Signed-off-by: oops-oom <734819342@qq.com>
Signed-off-by: oops-oom <734819342@qq.com>
* gateway-api: more gateway doc
* tweak
* Update content/en/docs/setup/additional-setup/gateway/index.md
Co-authored-by: John Howard <howardjohn@google.com>
Co-authored-by: John Howard <howardjohn@google.com>
* gateway-api doc: ingress-sni-passthrough
* use kustomize for crds
* debug
* more debug
* use standard crd install
* try profile=none
* uninstall
* confirm install
* disable test for now
* regen
* use short_codes for gateway api version and tpye
* Update function name. Forcing name doesn't work for boilerplates?
* Fix lint
* Remove k8s_gateway_api_type
* Add update-gateway-version mkaefile target
* Fix version in test string
* Simplify id
* Fix ingress control doc related to other providers and numbering
* Run make gen
* Add back TCP_INGRESS_PORT
* Revert to dash seperator for consistency
* build an archive of v1.14 in master
* update data/versions.yml and archive index page
* advance master to release-1.16
* Rerun `make update_ref_docs
* Update to commit on main branch to fix tests
* Disable failing test (temporary)
* Promoted command x uninstall to install
Signed-off-by: Tong Li <litong01@us.ibm.com>
* Promoted command x uninstall to install
Signed-off-by: Tong Li <litong01@us.ibm.com>
* Promoted command x uninstall to install
Signed-off-by: Tong Li <litong01@us.ibm.com>
* Update content/en/docs/setup/install/operator/test.sh
Promoted command x uninstall to install
Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>
Signed-off-by: Tong Li <litong01@us.ibm.com>
Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>
* Update test ref to 1.15.0-beta.1
* Change order for hem test output
* Go back to most likely sort over, but remove REV since it may change.
* Update test to just verify that both revisions exist
* But the revisions back in the doc
* Advanced Helm chart customization doc
As per the WG meeting, it was decided not to allow support for new values in istio helm charts
(unless there is substantial evidence it is needed by a large number of people); instead create an istio.io doc on last mile helm customization
Signed-off-by: Faseela K <faseela.k@est.tech>
* Update references section
Signed-off-by: Faseela K <faseela.k@est.tech>
* Add link to the new document in the main helm install page
Signed-off-by: Faseela K <faseela.k@est.tech>
* incorporate review comments
Signed-off-by: Faseela K <faseela.k@est.tech>
* Fix lint error
Signed-off-by: Faseela K <faseela.k@est.tech>
* Incorporate additional review comments
Signed-off-by: Faseela K <faseela.k@est.tech>
* Review comments, and fix deployment name in kustomize patch
Signed-off-by: Faseela K <faseela.k@est.tech>
* Fix helm template command
Signed-off-by: Faseela K <faseela.k@est.tech>
* specify namespace in the helm commands
Signed-off-by: Faseela K <faseela.k@est.tech>
* format helm template command output
Signed-off-by: Faseela K <faseela.k@est.tech>
* Fix intend
Signed-off-by: Faseela K <faseela.k@est.tech>
* add tests to gateway setup
* manually cleanup the minimal istio install
* Add canary upgrade test
* convert rewrite-repo to a helper function
* upgrade helm test
* lint fixes
* left over validatingwebhook from a prior test
* remove boilerplate check
* undo elided pod names
* gen snip
* Remove validatingwebhookconfigurations deletion
* remove webhook configs pending fix in istio
* remove webhook configs pending fix in istio
* revert some changes
* remove temp webhook removals
* remove revision labeled mutating webhooks
* revert revision-tags-middle change
* make gen
Daniel Hawton
Xiaopeng Han
Eric Van Norman
rrobb-aspen
John Howard
Yang Gang
Keith Mattix II
zhengbingxian
Patrik Jonsson
Arka Bhattacharya
Jackie Elliott
Bilal
Phill Gibson
Jonh Wendell
Ravi Verma
SRodi
Kalya Subramanian
zirain
Frank Budinsky
Faseela K
demotascha
Michael
Istio Automation
Michael
vasu1124
oops-oom
Tong Li
Oliver Liu
Zhonghu Xu
Daniel Hawton