Commit Graph

2 Commits

Author SHA1 Message Date
Frank Budinsky c727b0c083
Fix snip generator stripping leading space in expected output (#14693)
* Fix snip generator stripping leading space in expected output

* also fix _out

* strip trailing newline

* regen

* tweak for readability

* remove ambient label
2024-03-07 12:29:19 -08:00
Suchith J N 4b601f607e
automated test for zipkin dashboard and modify snippet generation to take boilerplate into account (#8003)
* automated test for viewing traces from zipkin dashboard (expectation is that traces are seen correctly)

* fix shellcheck linting errors

* remove verification of traces and just check if zipkin dashboard is accessible through port-forward

* Modify snippet generation logic to take {{< boilerplate >}} into account

* snippets for boilerplate

* fix shellcheck (linting) issues

* snippets generated with new logic

* automated test - check if zipkin dashboard is accessible by port-forwarding (as we cannot verify screenshot and the trace is already verified in istio/istio integration test

* clean up ZIPKIN_URL comment

* Address code review comments
1. Simplify boilerplate snippet filenames (remove .md_snips)
2. Sourced filenames should be in double quote(") instead of single quote(')

* fix gencheck_istio flake

* do not generate or include boilerplate snippets if there is not {{<text>}} in them

* fix linting errors in snip.py

* fix bug - filter out boilerplates without snippets very early
2020-08-26 08:37:50 -07:00