Commit Graph

3 Commits

Author SHA1 Message Date
Suchith J N 4b601f607e
automated test for zipkin dashboard and modify snippet generation to take boilerplate into account (#8003)
* automated test for viewing traces from zipkin dashboard (expectation is that traces are seen correctly)

* fix shellcheck linting errors

* remove verification of traces and just check if zipkin dashboard is accessible through port-forward

* Modify snippet generation logic to take {{< boilerplate >}} into account

* snippets for boilerplate

* fix shellcheck (linting) issues

* snippets generated with new logic

* automated test - check if zipkin dashboard is accessible by port-forwarding (as we cannot verify screenshot and the trace is already verified in istio/istio integration test

* clean up ZIPKIN_URL comment

* Address code review comments
1. Simplify boilerplate snippet filenames (remove .md_snips)
2. Sourced filenames should be in double quote(") instead of single quote(')

* fix gencheck_istio flake

* do not generate or include boilerplate snippets if there is not {{<text>}} in them

* fix linting errors in snip.py

* fix bug - filter out boilerplates without snippets very early
2020-08-26 08:37:50 -07:00
Frank Budinsky 41d56d97ff
Remove -it from kubectl exec calls (#7916) 2020-08-11 12:40:58 -07:00
Navraj Singh Chhina b76fd3d2f4
Using an External HTTPS Proxy Automated Test (#7886)
* add missing cleanup for vs nginx

* add test

* fix sourcepod

* add ...

* use verify contains

* revert boilerplate

* disable SC2155

* remove waitfordep

* add test

* fix newline

* weird cleanup

* add back test

* oops make gen

* Apply suggestions from code review

Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>

* weird cleanup

Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>
2020-08-10 15:39:55 -04:00