The old logic was very fragile. It relied either on legacy/insecure SA
key, or a *specific* account being used with WI.
We switched which account we use for WI, causing it to disable WI.
I don't think we need this subtlety. We already allow opting out of RBE
by the `BAZEL_BUILD_RBE_INSTANCE` variable -- which we already set when
we want to opt out -- so this should be fine. Additionally, the places
we don't want RBE (our private infra) do not have access to RBE, so if
they somehow tried to use it they would fail.
This simplifies the logic, and should re-enable RBE again
* Re-enable RBE (execution for Ubuntu, cache for CentOS).
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
* review: sync .bazelrc and .bazelversion from upstream.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
* review: Kick CI.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
* review: disable RBE execution until we have LARGE_MACHINES.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
* review: allow to override BAZEL_BUILD_RBE_JOBS.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
* review: disable RBE execution in CentOS postsubmit.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
* review: Kick CI.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
* review: Kick CI.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
* Re-enable RBE.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
* review: use only RBE cache.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
* review: Kick CI.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
* Add Prow presubmit verifying that the release scripts work.
This was removed in #2475, while retiring CircleCI jobs,
and it backfired 3 commits later...
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
* review: git add prow/proxy-presubmit-release.sh...
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
* metric record and integration test
* make test run
* make circle pass
* update go path
* try fix prow
* update sd filter and test
* clean
* remove direction from stackdriver config
* cleanup comment
* address comment
* fix build
* recover fake sd server
* add test prefix to field name
* update test config
* initial commit
* Add common as a dep
* add common context
* WIP3
* WIP5
* WIP7
* WIP3
* unblock client config
* write mapper
* add mapper
* added all 4 http metrics
* fix fast cache key
* Temporarily disable test
* enable common test
* review comments
* add explicit initialization to mappings
* more review comments
* more comments2
* make cache return reference instead of a pointer
* remove copy
* WIP direct mapping
* more direct code
* more simplification
* refactor common, and StatsGen
* add httbin backend for testing, add better logging
* fix test namespace
* prepare to add custom hash
* add trivial local httpbin impl for testing
* which to absl:hashValue
* add missing test file
* fix nits
* add license header
* fix function name
* set max cache size
* make istio_dimensions_ a member of rootContext. The mappings are overwritten before evaluation
* elimiate Node abstraction from NodeInfoCache
* try V4 only testing for prow
* Fix getMetadataStruct return values
Automatic merge from submit-queue.
Use a bazel.rc for build
**What this PR does / why we need it**:
bazel tends to use a lot of memory. Trying to bring it down.
```release-note
```
Automatic merge from submit-queue.
Update envoy to 07c2bf9
**What this PR does / why we need it**:
Update envoy to 07c2bf971c
- Use AsyncClientFactory in gRPC transport.
**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
**Special notes for your reviewer**:
**Release note**:
```release-note
NONE
```
Automatic merge from submit-queue.
Split presubmit tests
**What this PR does / why we need it**:
Current presubmit test takes more than 1 hour. Split it into 3 and run them parallel.
**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
**Special notes for your reviewer**:
**Release note**:
```release-note
None
```
Automatic merge from submit-queue.
Update envoy to e2117cb
**What this PR does / why we need it**:
Update Envoy to e2117cbf1f
Align with https://github.com/envoyproxy/envoy/pull/2386
**Release note**:
```release-note
None
```
Kevin Burek