jenkinsci
/
configuration-as-code-plugin
mirror of https://github.com/jenkinsci/configuration-as-code-plugin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

use hudson.util.Secret as a makrer type for sensitive data and never expose unencrypted value 

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
This commit is contained in:
Nicolas De Loof 2018-09-25 12:18:16 +02:00 committed by Nicolas De loof
parent 41e9ad8979
commit 11fd45b674
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
integrations/src/test/java/io/jenkins/plugins/casc/SystemCredentialsTest.java
View File

@ -59,7 +59,7 @@ public class SystemCredentialsTest {
ConfiguratorRegistry registry = ConfiguratorRegistry.get();
final ConfigurationContext context = new ConfigurationContext(registry);
final CNode node = context.lookup(up.getClass()).describe(up, context);
assertEquals("1234", node.asMapping().getScalarValue("password"));
assertThat(node.asMapping().getScalarValue("password"), not(equals("1234")));
List<CertificateCredentials> certs = CredentialsProvider.lookupCredentials(

4
plugin/src/main/java/io/jenkins/plugins/casc/impl/configurators/PrimitiveConfigurator.java
View File

@ -1,5 +1,6 @@
package io.jenkins.plugins.casc.impl.configurators;
import hudson.util.Secret;
import io.jenkins.plugins.casc.Attribute;
import io.jenkins.plugins.casc.ConfigurationContext;
import io.jenkins.plugins.casc.Configurator;
@ -90,6 +91,9 @@ public class PrimitiveConfigurator implements Configurator {
if (instance instanceof Boolean) {
return new Scalar((Boolean) instance);
}
if (instance instanceof Secret) {
return new Scalar(((Secret) instance).getEncryptedValue());
}
if (target.isEnum()) {
return new Scalar((Enum) instance);
}