jenkinsci
/
configuration-as-code-plugin
mirror of https://github.com/jenkinsci/configuration-as-code-plugin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Escape newSource field when checking it's value via Ajax. Fix #1401 (#1402) 

URLs with special characters need to be escaped when checking the Yaml they are pointing to.
Example of such URL are S3 presigned URL: `https://jenkins-jcas-185562170416.s3.amazonaws.com/jenkins-conf.yml?AWSAccessKeyId=AKE123456789&Signature=HelloWorldJ%2F5QKc6TlbeHw%3D&Expires=1590364679`.
This commit is contained in:
Mohamed El Mouctar Haidara 2020-05-25 08:14:45 +02:00 committed by GitHub
parent fd11e16a6b
commit 68f35e44ce
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugin/src/main/resources/io/jenkins/plugins/casc/ConfigurationAsCode/index.jelly
View File

@ -30,7 +30,7 @@
<f:form method="post" action="replace" name="replace">
<h2>${%Replace configuration source with:}</h2>
<f:entry title="${%Path or URL}" field="newSource" >
<f:textbox checkUrl="'checkNewSource?newSource='+this.value" checkMethod="post" />
<f:textbox checkUrl="'checkNewSource?newSource='+escape(this.value)" checkMethod="post" />
</f:entry>
<f:bottomButtonBar>
<f:submit name="replace" value="${%Apply new configuration}"/>