karmada-io
/
karmada
mirror of https://github.com/karmada-io/karmada.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

suppress some useless logs (#224) 

Signed-off-by: RainbowMango <renhongcai@huawei.com>
This commit is contained in:
Hongcai Ren 2021-03-19 14:42:00 +08:00 committed by GitHub
parent 0290ebf253
commit 1bf2e6502f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/util/helper/workstatus.go
View File

@ -28,7 +28,7 @@ func AggregateResourceBindingWorkStatus(c client.Client, binding *workv1alpha1.R
}
if reflect.DeepEqual(binding.Status.AggregatedStatus, aggregatedStatuses) {
klog.Infof("New aggregatedStatuses are equal with old resourceBinding(%s/%s) AggregatedStatus, no update required.",
klog.V(4).Infof("New aggregatedStatuses are equal with old resourceBinding(%s/%s) AggregatedStatus, no update required.",
binding.Namespace, binding.Name)
return nil
}

7
pkg/util/objectwatcher/objectwatcher.go
View File

@ -52,7 +52,6 @@ func NewObjectWatcher(client client.Client, kubeClientSet kubernetes.Interface,
}
func (o *objectWatcherImpl) Create(clusterName string, desireObj *unstructured.Unstructured) error {
klog.Infof("Start to create resource %v/%v", desireObj.GetNamespace(), desireObj.GetName())
dynamicClusterClient, err := util.BuildDynamicClusterClient(o.Client, o.KubeClientSet, clusterName)
if err != nil {
klog.Errorf("Failed to build dynamic cluster client for cluster %s.", clusterName)
@ -73,6 +72,7 @@ func (o *objectWatcherImpl) Create(clusterName string, desireObj *unstructured.U
klog.Errorf("Failed to create resource %v, err is %v ", desireObj.GetName(), err)
return err
}
klog.Infof("Created resource(kind=%s, %s/%s) on cluster: %s", desireObj.GetKind(), desireObj.GetNamespace(), desireObj.GetName(), clusterName)
// record version
o.recordVersion(clusterObj, dynamicClusterClient.ClusterName)
@ -80,7 +80,6 @@ func (o *objectWatcherImpl) Create(clusterName string, desireObj *unstructured.U
}
func (o *objectWatcherImpl) Update(clusterName string, desireObj, clusterObj *unstructured.Unstructured) error {
klog.Infof("Start to update resource %v/%v", desireObj.GetNamespace(), desireObj.GetName())
dynamicClusterClient, err := util.BuildDynamicClusterClient(o.Client, o.KubeClientSet, clusterName)
if err != nil {
klog.Errorf("Failed to build dynamic cluster client for cluster %s.", clusterName)
@ -105,13 +104,14 @@ func (o *objectWatcherImpl) Update(clusterName string, desireObj, clusterObj *un
return err
}
klog.Infof("Updated resource(kind=%s, %s/%s) on cluster: %s", desireObj.GetKind(), desireObj.GetNamespace(), desireObj.GetName(), clusterName)
// record version
o.recordVersion(resource, clusterName)
return nil
}
func (o *objectWatcherImpl) Delete(clusterName string, desireObj *unstructured.Unstructured) error {
klog.Infof("Start to delete resource %v/%v", desireObj.GetNamespace(), desireObj.GetName())
dynamicClusterClient, err := util.BuildDynamicClusterClient(o.Client, o.KubeClientSet, clusterName)
if err != nil {
klog.Errorf("Failed to build dynamic cluster client for cluster %s.", clusterName)
@ -132,6 +132,7 @@ func (o *objectWatcherImpl) Delete(clusterName string, desireObj *unstructured.U
klog.Errorf("Failed to delete resource %v, err is %v ", desireObj.GetName(), err)
return err
}
klog.Infof("Deleted resource(kind=%s, %s/%s) on cluster: %s", desireObj.GetKind(), desireObj.GetNamespace(), desireObj.GetName(), clusterName)
objectKey := o.genObjectKey(desireObj)
o.deleteVersionRecord(dynamicClusterClient.ClusterName, objectKey)

3
pkg/util/worker.go
View File

@ -111,7 +111,8 @@ func GenerateKey(obj interface{}) (QueueKey, error) {
func getClusterNameFromLabel(resource *unstructured.Unstructured) (string, error) {
workNamespace := GetLabelValue(resource.GetLabels(), WorkNamespaceLabel)
if len(workNamespace) == 0 {
klog.Infof("Resource(%s/%s/%s) not created by karmada", resource.GetKind(), resource.GetNamespace(), resource.GetName())
klog.V(4).Infof("Ignore resource(%s/%s/%s) which not managed by karmada", resource.GetKind(), resource.GetNamespace(), resource.GetName())
return "", nil
}
cluster, err := names.GetClusterName(workNamespace)