improve test coverage for validation

Signed-off-by: AllenZMC <zhongming.chang@daocloud.io>
This commit is contained in:
AllenZMC 2022-06-28 22:17:33 +08:00
parent 4a243f447a
commit 286026b3bf
1 changed files with 57 additions and 0 deletions

View File

@ -218,3 +218,60 @@ func TestValidatePolicyFieldSelector(t *testing.T) {
})
}
}
func TestEmptyOverrides(t *testing.T) {
tests := []struct {
name string
overriders policyv1alpha1.Overriders
want bool
}{
{
name: "empty overrides",
overriders: policyv1alpha1.Overriders{},
want: true,
},
{
name: "non-empty overrides",
overriders: policyv1alpha1.Overriders{
Plaintext: []policyv1alpha1.PlaintextOverrider{
{
Path: "spec/image",
},
},
},
want: false,
},
{
name: "non-empty overrides",
overriders: policyv1alpha1.Overriders{
Plaintext: []policyv1alpha1.PlaintextOverrider{
{
Path: "spec/image",
},
},
ImageOverrider: []policyv1alpha1.ImageOverrider{
{
Component: "Registry",
Operator: "remove",
Value: "fictional.registry.us",
},
},
CommandOverrider: []policyv1alpha1.CommandArgsOverrider{
{
ContainerName: "nginx",
Operator: "add",
Value: []string{"echo 'hello karmada'"},
},
},
},
want: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if got := EmptyOverrides(tt.overriders); got != tt.want {
t.Errorf("EmptyOverrides() = %v, want %v", got, tt.want)
}
})
}
}