Merge pull request #2898 from RainbowMango/pr_cleanup_atomic_pointer

Remove redundant pointer use of atomic types
This commit is contained in:
karmada-bot 2022-12-01 19:35:13 +08:00 committed by GitHub
commit 472ccb5a2d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 13 deletions

View File

@ -32,9 +32,9 @@ type ConfigManager interface {
// interpreterConfigManager collects the resource interpreter customization.
type interpreterConfigManager struct {
initialSynced *atomic.Bool
initialSynced atomic.Bool
lister cache.GenericLister
configuration *atomic.Value
configuration atomic.Value
}
// LuaScriptAccessors returns all cached configurations.
@ -63,12 +63,8 @@ func (configManager *interpreterConfigManager) HasSynced() bool {
// NewInterpreterConfigManager watches ResourceInterpreterCustomization and organizes
// the configurations in the cache.
func NewInterpreterConfigManager(informer genericmanager.SingleClusterInformerManager) ConfigManager {
manager := &interpreterConfigManager{
initialSynced: &atomic.Bool{},
configuration: &atomic.Value{},
}
manager := &interpreterConfigManager{}
manager.configuration.Store(make(map[schema.GroupVersionKind]CustomAccessor))
manager.initialSynced.Store(false)
// In interpret command, rules are not loaded from server, so we don't start informer for it.
if informer != nil {

View File

@ -31,9 +31,9 @@ type ConfigManager interface {
// interpreterConfigManager collect the resource interpreter webhook configuration.
type interpreterConfigManager struct {
configuration *atomic.Value
configuration atomic.Value
lister cache.GenericLister
initialSynced *atomic.Bool
initialSynced atomic.Bool
}
// HookAccessors return all configured resource interpreter webhook.
@ -62,13 +62,10 @@ func (m *interpreterConfigManager) HasSynced() bool {
// NewExploreConfigManager return a new interpreterConfigManager with resourceinterpreterwebhookconfigurations handlers.
func NewExploreConfigManager(inform genericmanager.SingleClusterInformerManager) ConfigManager {
manager := &interpreterConfigManager{
configuration: &atomic.Value{},
lister: inform.Lister(resourceExploringWebhookConfigurationsGVR),
initialSynced: &atomic.Bool{},
lister: inform.Lister(resourceExploringWebhookConfigurationsGVR),
}
manager.configuration.Store([]WebhookAccessor{})
manager.initialSynced.Store(false)
configHandlers := fedinformer.NewHandlerOnEvents(
func(_ interface{}) { manager.updateConfiguration() },